Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Andy Whitcroft
On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: > > Andy, > > good catch. > > We should rather check for V190 support only in case any > compat feature flags are actually set. > > { > + if (le32_to_cpu(sb->compat_features) && > + le32_to_cpu(sb->compat_featur

Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Heinz Mauelshagen
On 10/11/2016 05:38 PM, Andy Whitcroft wrote: On Tue, Oct 11, 2016 at 05:04:34PM +0200, Heinz Mauelshagen wrote: Andy, good catch. We should rather check for V190 support only in case any compat feature flags are actually set. { + if (le32_to_cpu(sb->compat_features) && + l

Re: [dm-devel] [PATCH 1/1] dm raid: fix compat_features validation

2016-10-11 Thread Heinz Mauelshagen
Andy, good catch. We should rather check for V190 support only in case any compat feature flags are actually set. I.e.: diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c index 8abde6b..2a39700 100644 --- a/drivers/md/dm-raid.c +++ b/drivers/md/dm-raid.c @@ -2258,7 +2258,8 @@ static in