Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 06:05:53PM -0400, Vivek Goyal wrote: > On Tue, Oct 02, 2012 at 01:52:50PM -0700, Kent Overstreet wrote: > > On Tue, Oct 02, 2012 at 11:12:02AM -0400, Vivek Goyal wrote: > > > On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > > > > This adds a pointer to the

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Vivek Goyal
On Tue, Oct 02, 2012 at 01:52:50PM -0700, Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 11:12:02AM -0400, Vivek Goyal wrote: > > On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > > > This adds a pointer to the bvec array to struct bio_integrity_payload, > > > instead of the bvec

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Vivek Goyal
On Tue, Oct 02, 2012 at 02:00:06PM -0700, Kent Overstreet wrote: > On Tue, Oct 02, 2012 at 11:37:37AM -0400, Vivek Goyal wrote: > > On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > > > > [..] > > > /** > > > * bio_integrity_alloc - Allocate integrity payload and attach it to b

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 11:12:02AM -0400, Vivek Goyal wrote: > On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > > This adds a pointer to the bvec array to struct bio_integrity_payload, > > instead of the bvecs always being inline; then the bvecs are allocated > > with bvec_alloc_b

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Kent Overstreet
On Tue, Oct 02, 2012 at 11:37:37AM -0400, Vivek Goyal wrote: > On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > > [..] > > /** > > * bio_integrity_alloc - Allocate integrity payload and attach it to bio > > * @bio: bio to attach integrity metadata to > > @@ -84,37 +47,39 @

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Vivek Goyal
On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: [..] > /** > * bio_integrity_alloc - Allocate integrity payload and attach it to bio > * @bio: bio to attach integrity metadata to > @@ -84,37 +47,39 @@ struct bio_integrity_payload *bio_integrity_alloc(struct > bio *bio, >

Re: [dm-devel] [PATCH v3 02/26] block: Convert integrity to bvec_alloc_bs()

2012-10-02 Thread Vivek Goyal
On Mon, Sep 24, 2012 at 03:34:42PM -0700, Kent Overstreet wrote: > This adds a pointer to the bvec array to struct bio_integrity_payload, > instead of the bvecs always being inline; then the bvecs are allocated > with bvec_alloc_bs(). Ok, you are introducing bio_vec pointer in this patch. May be w