Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread John Fastabend
On 8/13/2012 10:01 AM, Al Viro wrote: On Mon, Aug 13, 2012 at 09:58:12AM -0700, John Fastabend wrote: [...] HOWEVER, it still doesn't address more fundamental problem - somebody creating a socket and passing it to you in SCM_RIGHTS datagram will leave you with a socket you can do IO on, still

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread Al Viro
On Mon, Aug 13, 2012 at 09:58:12AM -0700, John Fastabend wrote: > [...] > > >HOWEVER, it still doesn't address more fundamental problem - somebody > >creating a socket and passing it to you in SCM_RIGHTS datagram will > >leave you with a socket you can do IO on, still tagged according to who > >ha

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread John Fastabend
[...] HOWEVER, it still doesn't address more fundamental problem - somebody creating a socket and passing it to you in SCM_RIGHTS datagram will leave you with a socket you can do IO on, still tagged according to who had created it. AFAICS, the whole point of that exercise was to allow third-par

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread Al Viro
On Sun, Aug 12, 2012 at 11:23:59PM -0700, John Fastabend wrote: > >OK clearly I screwed it up thanks for reviewing Al. How about this. > > > > fdt = files_fdtable(files); > > for (fd = 0; fd < fdt->max_fds; fd++) { > > struct socket *sock; > >

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread Neil Horman
On Sun, Aug 12, 2012 at 10:55:17PM -0700, John Fastabend wrote: > On 8/12/2012 6:53 PM, Al Viro wrote: > > Ladies and gentlemen, who the devil had reviewed that little gem? > > > >commit 406a3c638ce8b17d9704052c07955490f732c2b8 > >Author: John Fastabend > >Date: Fri Jul 20 10:39:25 2012 +000

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-13 Thread Joe Perches
On Sun, 2012-08-12 at 22:55 -0700, John Fastabend wrote: > On 8/12/2012 6:53 PM, Al Viro wrote: > > Ladies and gentlemen, who the devil had reviewed that little gem? > > > > commit 406a3c638ce8b17d9704052c07955490f732c2b8 > > Author: John Fastabend > > Date: Fri Jul 20 10:39:25 2012 + []

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-12 Thread John Fastabend
OK clearly I screwed it up thanks for reviewing Al. How about this. fdt = files_fdtable(files); for (fd = 0; fd < fdt->max_fds; fd++) { struct socket *sock; int err = 0; sock = sockfd_loo

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-12 Thread John Fastabend
On 8/12/2012 6:53 PM, Al Viro wrote: Ladies and gentlemen, who the devil had reviewed that little gem? commit 406a3c638ce8b17d9704052c07955490f732c2b8 Author: John Fastabend Date: Fri Jul 20 10:39:25 2012 + is a bleeding bogosity that doesn't pass even the most cursory inspection

Re: [flame^Wreview] net: netprio_cgroup: rework update socket logic

2012-08-12 Thread Al Viro
On Mon, Aug 13, 2012 at 02:53:48AM +0100, Al Viro wrote: > if (old_priomap) > memcpy(new_priomap->priomap, old_priomap, ^^^ old_priomap->priomap, that is. -- To unsubscribe from thi