Re: [git patches] libata fixes

2013-01-22 Thread Linus Torvalds
On Mon, Jan 21, 2013 at 11:48 AM, Jeff Garzik wrote: > Please pull 803739d25c2343da6d2f95eebdcbc08bf67097d4 from > git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > tags/upstream-linus >From the tag message: " Thought: I wonder if sparse could have caught this, someh

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Michael Tokarev
On 02.10.2012 23:59, Jeff Garzik wrote: > On 10/02/2012 03:44 PM, Michael Tokarev wrote: >> On 02.10.2012 23:40, Jeff Garzik wrote: >> >>> Minor libata updates, nothing notable. >>> >>> 1) Apply -- and then revert -- the FUA feature. Caused >>> disk corruption in linux-next, proving it cannot

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Jeff Garzik
On 10/02/2012 03:44 PM, Michael Tokarev wrote: On 02.10.2012 23:40, Jeff Garzik wrote: Minor libata updates, nothing notable. 1) Apply -- and then revert -- the FUA feature. Caused disk corruption in linux-next, proving it cannot be turned on by default. Any details on that? Disk c

Re: [git patches] libata fixes for 3.7

2012-10-02 Thread Michael Tokarev
On 02.10.2012 23:40, Jeff Garzik wrote: > Minor libata updates, nothing notable. > > 1) Apply -- and then revert -- the FUA feature. Caused >disk corruption in linux-next, proving it cannot be turned on by >default. Any details on that? Disk corruprion is rather a nasty side-effect ind

Re: [git patches] libata fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Sunday 24 February 2008, Alan Cox wrote: > > From the patch description it can't be told whether the patch itself is > > correct and only the patch description is bogus... > > zero length PRD misparsing. If I remember rightly old IDE never generates > 64K PRD slots because other hardware can't

Re: [git patches] libata fixes

2008-02-24 Thread Alan Cox
> From the patch description it can't be told whether the patch itself is > correct and only the patch description is bogus... zero length PRD misparsing. If I remember rightly old IDE never generates 64K PRD slots because other hardware can't handle it either (CS5520/30 etc) -- To unsubscribe fro

Re: [git patches] libata fixes

2008-02-24 Thread Bartlomiej Zolnierkiewicz
On Sunday 24 February 2008, Jeff Garzik wrote: [...] > Alan Cox (1): > pata_atiixp: Use 255 sector limit AHCI needs sorting too but this deals with the old interface Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> [...] >> diff --git a/drivers/

Re: [git patches] libata fixes

2007-12-07 Thread Frans Pop
Jeff Garzik wrote: > libata disabling command queueing (aka NCQ) based on some hueristics for > detection device brokenness that ultimately turned out to be broken. > > Remove the broken hueristic and turn NCQ back on for all the wrongfully > maligned hard drives. Yay! -- To unsubscribe from

Re: [git patches] libata fixes

2007-11-20 Thread Jeff Garzik
Tejun Heo wrote: These are upstream patches I collected while Jeff is away. Thanks. * workaround for ATAPI tape drives * detection/suspend workarounds for several laptops * ICH8/9 port_enable fix ata_piix controller ID reorganization is included to ease the fixes. Please pull from 'upstream-l

Re: [git patches] libata fixes

2007-10-31 Thread Jeff Garzik
Mikael Pettersson wrote: That's my fault for misremembering the rule about the number of dashes before the other comments part :-( I'll remember better in the future. Well, I should have caught it and hand-edited it on my side too... Jeff - To unsubscribe from this list: send the li

Re: [git patches] libata fixes

2007-10-31 Thread Mikael Pettersson
On Tue, 30 Oct 2007 11:54:01 -0700 (PDT), Linus Torvalds wrote: > On Tue, 30 Oct 2007, Jeff Garzik wrote: > > > > Mikael Pettersson (2): > > sata_promise: ASIC PRD table bug workaround, take 2 > > sata_promise: cleanups > > You and Mikael need to sort out the way you send/accept patch

Re: [git patches] libata fixes

2007-10-30 Thread Junio C Hamano
Jan Engelhardt <[EMAIL PROTECTED]> writes: > On Oct 30 2007 12:31, Linus Torvalds wrote: >>On Tue, 30 Oct 2007, Jeff Garzik wrote: >>> >>> Can we change git-am to accept two dashes as well as three? :) >> >>Well, git-am actually used to be a lot less strict about the dashes, and >>we've made it

Re: [git patches] libata fixes

2007-10-30 Thread Jan Engelhardt
On Oct 30 2007 12:31, Linus Torvalds wrote: >On Tue, 30 Oct 2007, Jeff Garzik wrote: >> >> Can we change git-am to accept two dashes as well as three? :) >> >> It seems pretty common, not just with Mikael but several others who send >> patches to me. > >Well, git-am actually used to be a lot le

Re: [git patches] libata fixes

2007-10-30 Thread Linus Torvalds
On Tue, 30 Oct 2007, Jeff Garzik wrote: > > Can we change git-am to accept two dashes as well as three? :) > > It seems pretty common, not just with Mikael but several others who send > patches to me. Well, git-am actually used to be a lot less strict about the dashes, and we've made it *mor

Re: [git patches] libata fixes

2007-10-30 Thread Jeff Garzik
Linus Torvalds wrote: On Tue, 30 Oct 2007, Jeff Garzik wrote: Mikael Pettersson (2): sata_promise: ASIC PRD table bug workaround, take 2 sata_promise: cleanups You and Mikael need to sort out the way you send/accept patches. Both of these commits had stuff like this: Signe

Re: [git patches] libata fixes

2007-10-30 Thread Linus Torvalds
On Tue, 30 Oct 2007, Jeff Garzik wrote: > > Mikael Pettersson (2): > sata_promise: ASIC PRD table bug workaround, take 2 > sata_promise: cleanups You and Mikael need to sort out the way you send/accept patches. Both of these commits had stuff like this: Signed-off-by: Mikael

Re: [git patches] libata fixes

2007-07-04 Thread David Woodhouse
On Tue, 2007-07-03 at 18:21 +0100, Alan Cox wrote: > Chuck posted a link to an attachment in bugzilla not to anything from > version control. And the bugzilla bug clearly indicates who posted the > attachment. Probably Chuck should have posted the bug number as well. Perhaps it would have helped i

Re: [git patches] libata fixes

2007-07-03 Thread Alan Cox
> So instead of complaining to Jeff about this, you should look at YOUR OWN > damn system. It was apparently your "enterprise ready" stuff, used by > another Red Hat engineer, that screwed up. Umm no Linus. Chuck posted a link to an attachment in bugzilla not to anything from version control. A

Re: [git patches] libata fixes

2007-07-03 Thread Linus Torvalds
On Tue, 3 Jul 2007, Alan Cox wrote: > > > attribution. Probably because of some insane system he uses (he has a > > comment in that bugzilla about "patch from comment #14 is in CVS now.". > > > > CVS? What kind if insane setup do you have there at Red Hat? > > CVS is used for tracking patch se

Re: [git patches] libata fixes

2007-07-03 Thread Alan Cox
> attribution. Probably because of some insane system he uses (he has a > comment in that bugzilla about "patch from comment #14 is in CVS now.". > > CVS? What kind if insane setup do you have there at Red Hat? CVS is used for tracking patch sets for RPMS rather than source trees. Its quite good

Re: [git patches] libata fixes

2007-07-03 Thread Linus Torvalds
On Tue, 3 Jul 2007, Alan Cox wrote: > > > Chuck Ebbert (1): > > pata_ali: fix UDMA settings > > Could you please fix your git tree to have the proper credits for patches > you pull from bugzilla. > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242472 I don't think it is Jeff wh

Re: [git patches] libata fixes

2007-07-03 Thread Alan Cox
> Chuck Ebbert (1): > pata_ali: fix UDMA settings Could you please fix your git tree to have the proper credits for patches you pull from bugzilla. https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242472 Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

Re: [git patches] libata fixes

2007-06-28 Thread Mikael Pettersson
On Wed, 27 Jun 2007 03:35:26 -0400, Jeff Garzik wrote: >Tejun Heo (9): > libata: kill the infamous abnormal status message > libata: kill non-sense warning message > libata: be less verbose about hpa > libata: remove unused variable from ata_eh_reset() > libata: fix ata_dev

Re: [git patches] libata fixes

2007-06-27 Thread Linus Torvalds
On Wed, 27 Jun 2007, Jeff Garzik wrote: > > Such would be a diagnostic that would trigger on valid SCSI commands, when the > user is doing nothing wrong and the system can indeed complete the command > just fine. Additionally, this is moving us in the direction of what the IDE > driver has appa

Re: [git patches] libata fixes

2007-06-27 Thread Jeff Garzik
Andrew Morton wrote: On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: + /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a +* few ATAPI devices choke on such DMA requests. +*/ + if (unlikely(qc->nbytes & 15)) + return

Re: [git patches] libata fixes

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 03:35:26 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > + /* Don't allow DMA if it isn't multiple of 16 bytes. Quite a > + * few ATAPI devices choke on such DMA requests. > + */ > + if (unlikely(qc->nbytes & 15)) > + return 1; It might be worth e

Re: [git patches] libata fixes

2007-05-25 Thread Jeff Garzik
Mikael Pettersson wrote: On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote: Jeff Garzik (4): [libata] sata_promise: fix flags typo ... --- a/drivers/ata/sata_promise.c +++ b/drivers/ata/sata_promise.c @@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = { /

Re: [git patches] libata fixes

2007-05-25 Thread Mikael Pettersson
On Fri, 25 May 2007 18:03:07 -0400, Jeff Garzik wrote: >Jeff Garzik (4): > [libata] sata_promise: fix flags typo ... >--- a/drivers/ata/sata_promise.c >+++ b/drivers/ata/sata_promise.c >@@ -297,7 +297,7 @@ static const struct ata_port_info pdc_port_info[] = { > > /* board_2057x_pata */

Re: [git patches] libata fixes

2007-03-28 Thread Chuck Ebbert
Andrew Morton wrote: > > There is another metric to look at, too: the number of fixes which are > going into 2.6.x.y. If that fix count is high, and if those fixes fix bugs > which were not present in 2.6.x-1 then this is an indication that something > is wrong - many regressions are sneaking thr

Re: [git patches] libata fixes

2007-03-28 Thread Andrew Morton
On Wed, 28 Mar 2007 13:53:10 -0700 (PDT) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Wed, 28 Mar 2007, Jeff Garzik wrote: > > > > Jeff Garzik wrote: > > > This disables libata ACPI, among other things. > > > > If a -rc6 is possible, that would be quite nice... > > Heh. I don't think -rc

Re: [git patches] libata fixes

2007-03-28 Thread Linus Torvalds
On Wed, 28 Mar 2007, Jeff Garzik wrote: > > Jeff Garzik wrote: > > This disables libata ACPI, among other things. > > If a -rc6 is possible, that would be quite nice... Heh. I don't think -rc6 is "possible" - it's "inevitable". We have too much fallout from the timer changes still outstanding.

Re: [git patches] libata fixes

2007-03-27 Thread Jeff Garzik
Jeff Garzik wrote: This disables libata ACPI, among other things. If a -rc6 is possible, that would be quite nice... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel

Re: [git patches] libata fixes

2007-03-19 Thread Alan Cox
On Mon, Mar 19, 2007 at 08:48:00AM +0100, Paul Rolland wrote: > Would you agree to a patch to add a kernel boot parameter to skip some > ata ports ? It should in theory not be neccessary > I found some archives refering to some "ataX=noprobe", but it seems > to have no effect, and I'd like to res

Re: [git patches] libata fixes

2007-03-18 Thread Tejun Heo
Paul Rolland wrote: Oh... that's just weird. It seems you'll have to continue boot with the timeouts for the time being. Sorry about that. Would you agree to a patch to add a kernel boot parameter to skip some ata ports ? I found some archives refering to some "ataX=noprobe", but it seems to

RE: [git patches] libata fixes

2007-03-18 Thread Paul Rolland
> Oh... that's just weird. It seems you'll have to continue > boot with the > timeouts for the time being. Sorry about that. Would you agree to a patch to add a kernel boot parameter to skip some ata ports ? I found some archives refering to some "ataX=noprobe", but it seems to have no effect,

Re: [git patches] libata fixes

2007-03-18 Thread Tejun Heo
Paul Rolland wrote: > Doh ! Got that : > > > ACPI: PCI Interrupt :00:1f.2[B] -> GSI 23 (level, low) -> IRQ 23 > ahci :00:1f.2: AHCI 0001.0100 32 slots 4 ports 3 Gbps 0xf impl SATA mode > ahci :00:1f.2: flags: 64bit ncq led clo pio slum part > ata1: SATA max UDMA/133 cmd 0xc20

RE: [git patches] libata fixes

2007-03-18 Thread Paul Rolland
Doh ! Got that : ACPI: PCI Interrupt :00:1f.2[B] -> GSI 23 (level, low) -> IRQ 23 ahci :00:1f.2: AHCI 0001.0100 32 slots 4 ports 3 Gbps 0xf impl SATA mode ahci :00:1f.2: flags: 64bit ncq led clo pio slum part ata1: SATA max UDMA/133 cmd 0xc208e900 ctl 0x b

RE: [git patches] libata fixes

2007-03-18 Thread Paul Rolland
Hi, > This is NCQ protocol violation on the drive's side shown on some early > drives. No need to worry too much about it. The drive will just get > blacklisted for NCQ and should work fine. > Thx. Also, remember one of the problem I have, with ata2 going to timeout because this port of the I

Re: [git patches] libata fixes

2007-03-18 Thread Tejun Heo
Paul Rolland wrote: > Hello, > >> Yeap, more than three HSM violations in ten minutes. That's the >> criteria for turning off NCQ. Good to see it working. It look like a >> lot because libata reports all active commands (can't help as on HSM >> failure, there's no way to determine which caused

RE: [git patches] libata fixes

2007-03-18 Thread Paul Rolland
Hello, > Yeap, more than three HSM violations in ten minutes. That's the > criteria for turning off NCQ. Good to see it working. It look like a > lot because libata reports all active commands (can't help as on HSM > failure, there's no way to determine which caused it) and the SCSI > prints re

Re: [git patches] libata fixes

2007-03-18 Thread Tejun Heo
Paul Rolland wrote: > Hello, > >> Can you put the harddisk under high load and see what happens? How >> often do those errors occur? Care to post full dmesg? > > I started again a stock 2.6.21-rc4, and ran that : > while (/bin/true); do tar jxf linux-2.6.19.1.tar.bz2; rm -rf linux-2.6.19.1; > e

RE: [git patches] libata fixes

2007-03-18 Thread Paul Rolland
Hello, > Can you put the harddisk under high load and see what happens? How > often do those errors occur? Care to post full dmesg? I started again a stock 2.6.21-rc4, and ran that : while (/bin/true); do tar jxf linux-2.6.19.1.tar.bz2; rm -rf linux-2.6.19.1; echo -n "."; done After seve

Re: [git patches] libata fixes

2007-03-17 Thread Tejun Heo
Paul Rolland wrote: > Hello, > >> The kernel says that NCQ is turned off due to excessive >> errors. If your >> HSM violation is intermittent, it might not trigger tho. > > I've just grep'ed thru all my messages, and I can't find anything > stating that NCQ is being turned off... Can you put

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
Hello, > The kernel says that NCQ is turned off due to excessive > errors. If your > HSM violation is intermittent, it might not trigger tho. I've just grep'ed thru all my messages, and I can't find anything stating that NCQ is being turned off... Paul - To unsubscribe from this list: send

Re: [git patches] libata fixes

2007-03-17 Thread Tejun Heo
Paul Rolland wrote: >> If you leave it alone, does libata turn off NCQ and boot continues? > > boot continues, but I can't tell anything about libata turning of NCQ... > I've had a bunch of them at some while while compiling some kernel, so it > was quite some time after booting. > > Is there a m

Re: [git patches] libata fixes

2007-03-17 Thread Alan Cox
> > > > > > > > > Signed-off-by: Paul Rolland <[EMAIL PROTECTED]> > > > > NAK - but add the firmware to the match and you can have an Ack 8) > > Second try, compiled _and_ boot tested, of course. > > dmesg says : > ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > ata1.00: ATA-7: Maxto

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
> If you leave it alone, does libata turn off NCQ and boot continues? boot continues, but I can't tell anything about libata turning of NCQ... I've had a bunch of them at some while while compiling some kernel, so it was quite some time after booting. Is there a message I can check for that would

Re: [git patches] libata fixes

2007-03-17 Thread Tejun Heo
Paul Rolland wrote: > Hello, > > I'm preparing to attach a disk. > In the meantime, I've rebuild a 2.6.21-rc4, and got that while booting : > ... > ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > ata1.00: ATA-7: Maxtor 6L250S0, BANC1G10, max UDMA/133 > ata1.00: 490234752 sectors, multi 0

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
Hello, > Please match the firmware version as well for the Maxtor drives Ok. > > --- linux-2.6.21-rc4/drivers/ata/libata-core.c 2007-03-17 > 19:29:45.0 > > +0100 > > +++ linux-2.6.21-rc4-Maxtor/drivers/ata/libata-core.c 2007-03-17 > > 19:37:28.0 +0100 > > @@ -3359,6 +3359,8 @

Re: [git patches] libata fixes

2007-03-17 Thread Alan Cox
On Sat, Mar 17, 2007 at 07:47:01PM +0100, Paul Rolland wrote: > Hello, > > Here is a patch to avoid these pesky messages for the Maxtor disk : > Please match the firmware version as well for the Maxtor drives > --- linux-2.6.21-rc4/drivers/ata/libata-core.c 2007-03-17 19:29:45.0 > +010

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
EMAIL PROTECTED] On Behalf Of Paul Rolland > Sent: Saturday, March 17, 2007 6:59 PM > To: 'Tejun Heo' > Cc: 'Linus Torvalds'; 'Jeff Garzik'; 'Alan Cox'; 'Andrew > Morton'; linux-ide@vger.kernel.org; 'LKML'; 'Eric D

Re: [git patches] libata fixes

2007-03-17 Thread Alan Cox
On Sat, Mar 17, 2007 at 06:59:12PM +0100, Paul Rolland wrote: > ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) > ata1.00: ATA-7: Maxtor 6L250S0, BANC1G10, max UDMA/133 That drive isn't in our current block list for NCQ but some close relatives are in the one I've compiled so far (7B250S0).

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
un Heo > Sent: Monday, March 12, 2007 9:05 AM > To: [EMAIL PROTECTED] > Cc: 'Linus Torvalds'; 'Jeff Garzik'; 'Alan Cox'; 'Andrew > Morton'; linux-ide@vger.kernel.org; 'LKML'; 'Eric D. Mudama' > Subject: Re: [git patches] libata

RE: [git patches] libata fixes

2007-03-17 Thread Paul Rolland
> > PS : I'd like to try 2.6.21-rc3, but it seems that this is > breaking my > > config : disk naming is no more the same, and I end up with a panic > > Warning: unable to open an initial console > > though i've been compiling with the same .config I was > using for 2.6.21-rc2 > > Gaah. Can you

RE: [git patches] libata fixes

2007-03-12 Thread Paul Rolland
Hello, > > That sounds a quite expensive solution ;) > > You should be able to just move the drive attached at ata1 to ata2. > Please report whether that works. I'll try to find an unused disk... As I said, these ports are part of Asus EZRaid solution, and i'd prefer this piece of code not to tr

Re: [git patches] libata fixes

2007-03-12 Thread Tejun Heo
Paul Rolland wrote: >> I keep forgetting about this. I'll ask SIMG how to deal with >> this. For >> the time being, connecting a device to the PMP port should remove the >> timeouts. > > That sounds a quite expensive solution ;) You should be able to just move the drive attached at ata1 to ata

RE: [git patches] libata fixes

2007-03-12 Thread Paul Rolland
Hello, > It involves a long timeout, so it's bothersome. This is caused by > Silicon Image 4726/3726 storage processor (SATA Port Multiplier with > extra features) attached to one of the ICH ports. Yes, I think this is the part Asus is using for it's EZ-Raid feature on this motherboard, and they

RE: [git patches] libata fixes

2007-03-11 Thread Paul Rolland
Hello, > Ok, so that's just a message irritation, not actually bothersome > otherwise? It is somewhat painful, because delays involved are quite long, and it is not possible to explain the machine to "ignore" the port, and skip to the next one... > > The second problem is a Jmicron363 control

Re: [git patches] libata fixes

2007-03-11 Thread Tejun Heo
Of course I forgot to CC. :-) Quoting whole message for Justin. Tejun Heo wrote: > Hello, Linus. > > Linus Torvalds wrote: >> On Sun, 11 Mar 2007, Paul Rolland wrote: >>> My machine is having two problems : the one you are describing above, >>> which is due to a SIL controler being connected to

Re: [git patches] libata fixes

2007-03-11 Thread Tejun Heo
Hello, Linus. Linus Torvalds wrote: > On Sun, 11 Mar 2007, Paul Rolland wrote: >> My machine is having two problems : the one you are describing above, >> which is due to a SIL controler being connected to one port of the ICH7 >> (at least, it seems to), and probing it goes timeout, but nothing i

RE: [git patches] libata fixes

2007-03-11 Thread Linus Torvalds
On Sun, 11 Mar 2007, Paul Rolland wrote: > > My machine is having two problems : the one you are describing above, > which is due to a SIL controler being connected to one port of the ICH7 > (at least, it seems to), and probing it goes timeout, but nothing is > connected on it. Ok, so that's ju

RE: [git patches] libata fixes

2007-03-11 Thread Paul Rolland
Hello, > > Nope... I tried several patches from Tejun, and also some > that Jeff posted > > to linux-ide, but no luck. The only way to have this DVD-RW > working is to > > use irqpoll on the command line... > > So it has *never* worked? That's what I'm trying to see - you had a > "before" and

RE: [git patches] libata fixes

2007-03-11 Thread Linus Torvalds
On Sun, 11 Mar 2007, Paul Rolland wrote: > > Nope... I tried several patches from Tejun, and also some that Jeff posted > to linux-ide, but no luck. The only way to have this DVD-RW working is to > use irqpoll on the command line... So it has *never* worked? That's what I'm trying to see - you

RE: [git patches] libata fixes

2007-03-11 Thread Paul Rolland
oundation > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Paul Rolland > Sent: Sunday, March 11, 2007 7:35 PM > To: 'Linus Torvalds' > Cc: 'Tejun Heo'; 'Jeff Garzik'; 'Andrew Morton';

RE: [git patches] libata fixes

2007-03-11 Thread Linus Torvalds
Paul, do I understand correctly that the *only* difference between the working setup is that you applied (by hand) the libata patch that Jeff sent out? So plain 2.6.21-rc2 works fine, but with the patch applied, you get no interrupts on the DVD drive? On Sun, 11 Mar 2007, Paul Rolland wrote:

RE: [git patches] libata fixes

2007-03-11 Thread Paul Rolland
Hello, > It seems like IRQ is not getting through. The first IRQ > driven command is failing for you. H > Extract is : > ata7: PATA max UDMA/100 cmd 0x00019c00 ctl 0x00019882 bmdma > 0x00019400 irq 16 > ata8: PATA max UDMA/100 cmd 0x00019800 ctl 0x00

Re: [git patches] libata fixes

2007-03-09 Thread Tejun Heo
Paul Rolland wrote: > Hell Tejun, > > I've boot-tested this yesterday, with no real luck... > > 1 - Tested on top of 2.6.21-rc2 (hope it's fine for you), > 2 - Collected a full dmesg before and after > > Extract is : > ata7: PATA max UDMA/100 cmd 0x00019c00 ctl 0x00019882 bmdma

RE: [git patches] libata fixes

2007-03-05 Thread Paul Rolland
Foundation > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Tejun Heo > Sent: Monday, March 05, 2007 4:45 PM > To: [EMAIL PROTECTED] > Cc: 'Jeff Garzik'; 'Andrew Morton'; 'Linus Torvalds'; > linux-

Re: [git patches] libata fixes

2007-03-05 Thread Tejun Heo
Paul Rolland wrote: > Hello, > >> Your drive has some issues with NCQ and is scheduled to be blacklisted >> such that it isn't enabled. libata used to ignore the >> condition but now >> considers it NCQ protocol violation and fails all pending commands. > > OK, do you need an hdparm report to f

RE: [git patches] libata fixes

2007-03-05 Thread Paul Rolland
Hello, > Your drive has some issues with NCQ and is scheduled to be blacklisted > such that it isn't enabled. libata used to ignore the > condition but now > considers it NCQ protocol violation and fails all pending commands. OK, do you need an hdparm report to fully identify the disk ? > lib

RE: [git patches] libata fixes

2007-03-05 Thread Paul Rolland
Hello, > 1. Has it ever worked with the previous kernels? I can't tell, this machine is new, and it never booted something that was not a 2.6.20 or 2.6.21. > 2. If you connect a harddisk to pata_jmicron, does it work? > > 3. Does applying the attached patch fix your problem? Will do these two

Re: [git patches] libata fixes

2007-03-04 Thread Tejun Heo
Hello, Paul Rolland wrote: > Hello, > > Applied this on top of 2.6.21-rc1 and your previous patch (see my previous > mail). > Still booting, no more the weird error I've reported minutes ago. > > pata_jmicron still unable to detect my DVD-RW : > scsi8 : pata_jmicron > ata9.00: ATAPI, max UDMA/6

Re: [git patches] libata fixes

2007-03-04 Thread Tejun Heo
[cc'ing Eric D. Mudama. Hi!] Paul Rolland wrote: > ata1.00: exception Emask 0x2 SAct 0xffe0 SErr 0x0 action 0x2 frozen > ata1.00: (spurious completions during NCQ issue=0x0 SAct=0xffe0 > FIS=004040a1:0010) > ata1.00: cmd 60/02:28:52:ec:c4/00:00:0e:00:00/40 tag 5 cdb 0x0 data 1024 in >

RE: [git patches] libata fixes

2007-03-03 Thread Paul Rolland
Hello, Applied this on top of 2.6.21-rc1, and I now have the following in my logs : ahci :00:1f.2: version 2.0 ACPI: PCI Interrupt :00:1f.2[B] -> GSI 23 (level, low) -> IRQ 23 PCI: Setting latency timer of device :00:1f.2 to 64 ahci :00:1f.2: AHCI 0001.0100 32 slots 4 ports 3 Gbps

Re: [git patches] libata fixes

2007-02-06 Thread Conke Hu
On Fri, 2007-02-02 at 11:58 -0500, Jeff Garzik wrote: > Brian and Tejun's patches fix really ugly bugs, Alan's are of less > importance > > Please pull from 'upstream-linus' branch of > master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git > upstream-linus > > to receive the followi

Re: [git patches] libata fixes

2007-02-02 Thread Linus Torvalds
On Fri, 2 Feb 2007, alan wrote: > > I just thought you meant a scenario involving schedenfreud. That would be sch*a*denfreud*e* Linus "I win!" Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED

Re: [git patches] libata fixes

2007-02-02 Thread alan
On Fri, 2 Feb 2007, Linus Torvalds wrote: On Fri, 2 Feb 2007, Andrew Morton wrote: http://www.google.com/search?hl=en&q=torvalds+schenario&btnG=Google+Search I know. But since people pointed it out, I've actually tried to mend my broken ways. And the fact that people always point out that

Re: [git patches] libata fixes

2007-02-02 Thread Linus Torvalds
On Fri, 2 Feb 2007, Andrew Morton wrote: > > http://www.google.com/search?hl=en&q=torvalds+schenario&btnG=Google+Search I know. But since people pointed it out, I've actually tried to mend my broken ways. And the fact that people always point out that _same_ misspelled word actually makes me

Re: [git patches] libata fixes

2007-02-02 Thread Andrew Morton
On Fri, 2 Feb 2007 09:13:56 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 2 Feb 2007, Jeff Garzik wrote: > > > > pata_atiixp: propogate cable detection hack from drivers/ide to the > > new driver > > It's prop*a*gate. > > Damn. > > Linus "some spel

Re: [git patches] libata fixes

2007-02-02 Thread Alan
On Fri, 2 Feb 2007 09:13:56 -0800 (PST) Linus Torvalds <[EMAIL PROTECTED]> wrote: > > > On Fri, 2 Feb 2007, Jeff Garzik wrote: > > > > pata_atiixp: propogate cable detection hack from drivers/ide to the > > new driver > > It's prop*a*gate. > > Damn. So add git-commit auto spelling fi

Re: [git patches] libata fixes

2007-02-02 Thread Jeff Garzik
Linus Torvalds wrote: On Fri, 2 Feb 2007, Jeff Garzik wrote: pata_atiixp: propogate cable detection hack from drivers/ide to the new driver It's prop*a*gate. Damn. Linus "some speling mistaeks drive me wild" Torvalds Those UK types don't know how to spell tons o

Re: [git patches] libata fixes

2007-02-02 Thread Linus Torvalds
On Fri, 2 Feb 2007, Jeff Garzik wrote: > > pata_atiixp: propogate cable detection hack from drivers/ide to the new > driver It's prop*a*gate. Damn. Linus "some speling mistaeks drive me wild" Torvalds - To unsubscribe from this list: send the line "unsubscribe linux-ke

Re: [git patches] libata fixes

2006-12-20 Thread Stephen Frost
* Jeff Garzik ([EMAIL PROTECTED]) wrote: > FWIW the Tejun cleanups are a fix, split into three reviewable pieces. > > Also, my local iomap branch has advanced sufficiently enough that I > think it's high time to kill those libata warnings that spew on every > build. (I hear the crowds roar) Perh

Re: [git patches] libata fixes

2006-11-30 Thread Renato S. Yamane
Renato S. Yamane escreveu: > Jeff Garzik escreveu: >> --- a/drivers/ata/pata_sil680.c >> +++ b/drivers/ata/pata_sil680.c >> @@ -225,6 +225,7 @@ static struct scsi_host_template sil680_ >> .proc_name = DRV_NAME, >> .dma_boundary = ATA_DMA_BOUNDARY, >> .slave_con

Re: [git patches] libata fixes

2006-11-30 Thread Renato S. Yamane
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeff Garzik escreveu: > --- a/drivers/ata/pata_sil680.c > +++ b/drivers/ata/pata_sil680.c > @@ -225,6 +225,7 @@ static struct scsi_host_template sil680_ > .proc_name = DRV_NAME, > .dma_boundary = ATA_DMA_BOUNDARY, >