Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-21 Thread Roland Dreier
> This driver should really have gotten some review before being included > in the kernel. > Even a simple checkpatch run finds more than > 250 stylistic errors > (not code bugs but cases where the driver violates the standard code > formatting rules of kernel code). Linus has strongly sta

Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-21 Thread Adrian Bunk
On Thu, Feb 21, 2008 at 06:39:45AM -0600, Glenn Streiff wrote: > > > > > No, 51af33e8 was for a similar same bug 400 lines below > > this bug... > > > > > > Heh, sorry. > > > > > > Glenn -- please review Adrian's patches and let me know > > which ones are > > > good to apply. > > > > > > >

RE: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-21 Thread Glenn Streiff
> > > No, 51af33e8 was for a similar same bug 400 lines below > this bug... > > > > Heh, sorry. > > > > Glenn -- please review Adrian's patches and let me know > which ones are > > good to apply. > > > I went ahead and created a patch series and attributed Adrian for the patches of his I l

RE: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-20 Thread Glenn Streiff
> -Original Message- > From: Roland Dreier [mailto:[EMAIL PROTECTED] > Sent: Wednesday, February 20, 2008 5:22 PM > To: Adrian Bunk > Cc: Faisal Latif; Glenn Streiff; linux-kernel@vger.kernel.org; > [EMAIL PROTECTED] > Subject: Re: [ofa-general] [2.6 patch] infiniba

Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-20 Thread Roland Dreier
> No, 51af33e8 was for a similar same bug 400 lines below this bug... Heh, sorry. Glenn -- please review Adrian's patches and let me know which ones are good to apply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More ma

Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-19 Thread Adrian Bunk
On Tue, Feb 19, 2008 at 08:23:19PM -0800, Roland Dreier wrote: > Thanks, this is already upstream as 51af33e8 No, 51af33e8 was for a similar same bug 400 lines below this bug... cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had b

Re: [ofa-general] [2.6 patch] infiniband/hw/nes/nes_verbs.c: fix off-by-one

2008-02-19 Thread Roland Dreier
Thanks, this is already upstream as 51af33e8 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/