Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-29 Thread Zhang, Yanmin
On Wed, 2006-11-29 at 09:35 +0100, Arjan van de Ven wrote: > Zhang, Yanmin wrote: > >> but second of all, the core2 cpus are dual core so.. .what does it > >> bring you at all? > > > > When there is only one cpu (or UP), the go backwards issue doesn't exist, > > it does exist for single-socket d

Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-29 Thread Zhang, Yanmin
On Wed, 2006-11-29 at 19:05 +1100, Nick Piggin wrote: > Arjan van de Ven wrote: > > Zhang, Yanmin wrote: > > > >> If it's a single processor, the go backwards issue doesn't exist. > >> Below is > >> my patch based on Arjan's. It's against 2.6.19-rc5-mm2. > > > > Hi, > > > > this patch is incorr

Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-29 Thread Arjan van de Ven
Zhang, Yanmin wrote: but second of all, the core2 cpus are dual core so.. .what does it bring you at all? When there is only one cpu (or UP), the go backwards issue doesn't exist, it does exist for single-socket dual core already. And core2 is dual core... so don't use cpuid here for UP.

Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-29 Thread Nick Piggin
Arjan van de Ven wrote: Zhang, Yanmin wrote: If it's a single processor, the go backwards issue doesn't exist. Below is my patch based on Arjan's. It's against 2.6.19-rc5-mm2. Hi, this patch is incorrect --- linux-2.6.19-rc5-mm2_arjan/arch/x86_64/kernel/setup.c 2006-11-29 10:41:21.

Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-28 Thread Arjan van de Ven
Zhang, Yanmin wrote: If it's a single processor, the go backwards issue doesn't exist. Below is my patch based on Arjan's. It's against 2.6.19-rc5-mm2. Hi, this patch is incorrect --- linux-2.6.19-rc5-mm2_arjan/arch/x86_64/kernel/setup.c 2006-11-29 10:41:21.0 +0800 +++ linux-2.6

Re: [patch] Mark rdtsc as sync only for netburst, not for core2

2006-11-28 Thread Andi Kleen
On Tuesday 28 November 2006 11:28, Arjan van de Ven wrote: > Hi, > > On the Core2 cpus, the rdtsc instruction is not serializing (as defined > in the architecture reference since rdtsc exists) and due to the deep > speculation of these cores, it's possible that you can observe time go > backwards