On Mon, Dec 19, 2016 at 04:40:30PM -0800, James Smart wrote:
> Dan,
>
> Mind if I solve this a different way ?
Not at all.
Could you give me a Reported-by tag?
regards,
dan carpenter
Dan,
Mind if I solve this a different way ? I really don't know why knowing
the ptr value is even meaningful
-- james
On 12/10/2016 1:06 AM, Dan Carpenter wrote:
We really don't care where "ctrl" is on the stack since we're just
returning soon what we want is the actual ctrl pointer itself
On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote:
>
> On Mon, 12 Dec 2016, Dan Carpenter wrote:
>
> > On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> > > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote
On Mon, 12 Dec 2016, Dan Carpenter wrote:
> On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_
On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:
> On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > > --- drivers//dma/pxa_dma.c
> > > +++ /tmp
On Sat, 2016-12-10 at 21:06 +0100, Julia Lawall wrote:
>
> On Sat, 10 Dec 2016, Dan Carpenter wrote:
>
> > On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> > > On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> > > > We really don't care where "ctrl" is on the stack since we'
On Sat, 2016-12-10 at 23:07 +0100, Julia Lawall wrote:
>
> On Sat, 10 Dec 2016, Joe Perches wrote:
>
> > On Sat, 2016-12-10 at 21:06 +0100, Julia Lawall wrote:
> > >
> > > On Sat, 10 Dec 2016, Dan Carpenter wrote:
> > >
> > > > On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> > >
On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:
> On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> > --- drivers//dma/pxa_dma.c
> > +++ /tmp/nothing//dma/pxa_dma.c
> > @@ -640,9 +640,6 @@ static unsigned int cle
On Sat, 10 Dec 2016, Joe Perches wrote:
> On Sat, 2016-12-10 at 21:06 +0100, Julia Lawall wrote:
> >
> > On Sat, 10 Dec 2016, Dan Carpenter wrote:
> >
> > > On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> > > > On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> > > > > We r
On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:
> diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c
> --- drivers//dma/pxa_dma.c
> +++ /tmp/nothing//dma/pxa_dma.c
> @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc
> dcsr = phy_readl_relaxed(phy, DCSR);
>
On Sat, 2016-12-10 at 21:06 +0100, Julia Lawall wrote:
>
> On Sat, 10 Dec 2016, Dan Carpenter wrote:
>
> > On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> > > On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> > > > We really don't care where "ctrl" is on the stack since we'
For my check, most of the results fall into three categories.
1) False positives (40% of results)
2) Badly designed interfaces that take a pointer to a pointer for no
reason and can be cleaned up. (5%)
3) Bugs where we modified the code, but haven't tested it. Most of the
time passing the w
On Sat, 10 Dec 2016, Dan Carpenter wrote:
> On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> > On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> > > We really don't care where "ctrl" is on the stack since we're just
> > > returning soon what we want is the actual ctrl point
On Sat, Dec 10, 2016 at 03:27:50AM -0800, Joe Perches wrote:
> On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> > We really don't care where "ctrl" is on the stack since we're just
> > returning soon what we want is the actual ctrl pointer itself.
> >
> > Signed-off-by: Dan Carpenter
> >
On Sat, 2016-12-10 at 12:06 +0300, Dan Carpenter wrote:
> We really don't care where "ctrl" is on the stack since we're just
> returning soon what we want is the actual ctrl pointer itself.
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/nvme/host/fc.c b/drivers/nvme/host/fc.c
[]
> @@
15 matches
Mail list logo
