Re: [patch] optimize o_direct on block device - v2

2006-12-05 Thread Andrew Morton
On Mon, 4 Dec 2006 20:55:50 -0800 "Chen, Kenneth W" <[EMAIL PROTECTED]> wrote: > This patch implements block device specific .direct_IO method instead > of going through generic direct_io_worker for block device. > > direct_io_worker is fairly complex because it needs to handle O_DIRECT > on file

Re: [patch] optimize o_direct on block device - v2

2006-12-05 Thread Andrew Morton
On Tue, 5 Dec 2006 11:02:30 + Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > + long res; > > + > > + if ((bio->bi_rw & 1) == READ) > > I just wanted to complain about not using a proper helper for this, > but apparently we don't have one yet.. There's bio_data_dir(). - To unsubscribe f

Re: [patch] optimize o_direct on block device - v2

2006-12-05 Thread Christoph Hellwig
On Mon, Dec 04, 2006 at 08:55:50PM -0800, Chen, Kenneth W wrote: > This patch implements block device specific .direct_IO method instead > of going through generic direct_io_worker for block device. > > direct_io_worker is fairly complex because it needs to handle O_DIRECT > on file system, where