Re: [patch] truncate_inode_pages

2001-06-12 Thread Dieter Nützel
Am Dienstag, 12. Juni 2001 14:32 schrieb Daniel Phillips: > On Tuesday 12 June 2001 02:00, you wrote: > > Now with -ac13 and the third try. > > Is it final? > > There have been no further problems reported, but it's Andrew Morton's > patch, his decision. > > -- > Daniel Hello Andrew, have you fo

Re: [patch] truncate_inode_pages

2001-06-11 Thread Andrew Morton
Daniel Phillips wrote: > > On Monday 11 June 2001 14:45, Andrew Morton wrote: > > Daniel Phillips wrote: > > > On Sunday 10 June 2001 03:31, Andrew Morton wrote: > > > > Daniel Phillips wrote: > > > > > This is easy, just set the list head to the page about to be > > > > > truncated. > > > > > >

Re: [patch] truncate_inode_pages

2001-06-11 Thread Daniel Phillips
On Monday 11 June 2001 14:45, Andrew Morton wrote: > Daniel Phillips wrote: > > On Sunday 10 June 2001 03:31, Andrew Morton wrote: > > > Daniel Phillips wrote: > > > > This is easy, just set the list head to the page about to be > > > > truncated. > > > > > > Works for me. > > > > It looks good, b

Re: [patch] truncate_inode_pages

2001-06-11 Thread Andrew Morton
Daniel Phillips wrote: > > On Sunday 10 June 2001 03:31, Andrew Morton wrote: > > Daniel Phillips wrote: > > > This is easy, just set the list head to the page about to be truncated. > > > > Works for me. > > It looks good, but it's black magic No, it's wrong. I'm getting BUG()s in clear_inode

Re: [patch] truncate_inode_pages

2001-06-10 Thread Dieter Nützel
> Daniel Phillips wrote: > > > > This is easy, just set the list head to the page about to be truncated. > > Works for me. > > --- linux-2.4.5/mm/filemap.cMon May 28 13:31:49 2001 > +++ linux-akpm/mm/filemap.c Sun Jun 10 11:29:19 2001 > @@ -235,12 +235,13 @@ [snip] Works for me 12 times

Re: [patch] truncate_inode_pages

2001-06-10 Thread Daniel Phillips
On Sunday 10 June 2001 03:31, Andrew Morton wrote: > Daniel Phillips wrote: > > This is easy, just set the list head to the page about to be truncated. > > Works for me. It looks good, but it's black magic - it could use a comment along the lines of: /* * Ensure at least one pass through all t

Re: [patch] truncate_inode_pages

2001-06-09 Thread Andrew Morton
Daniel Phillips wrote: > > This is easy, just set the list head to the page about to be truncated. Works for me. --- linux-2.4.5/mm/filemap.cMon May 28 13:31:49 2001 +++ linux-akpm/mm/filemap.c Sun Jun 10 11:29:19 2001 @@ -235,12 +235,13 @@ /* Is one of the pages to tr

Re: [patch] truncate_inode_pages

2001-06-09 Thread Daniel Phillips
On Saturday 09 June 2001 19:40, Alexander Viro wrote: > > takes 45 seconds CPU time due to the O(clean * dirty) algorithm in > > truncate_inode_pages(). The machine is locked up for the duration. > > The patch reduces this to 20 milliseconds via an O(clean + dirty) > > algorithm. > > Unfortunatel

Re: [patch] truncate_inode_pages

2001-06-09 Thread Alexander Viro
> takes 45 seconds CPU time due to the O(clean * dirty) algorithm in > truncate_inode_pages(). The machine is locked up for the duration. > The patch reduces this to 20 milliseconds via an O(clean + dirty) > algorithm. Unfortunately, it's _not_ O(clean + dirty). > + while (truncat