Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-07 Thread James Bottomley
On Fri, 2007-07-06 at 23:25 -0400, Douglas Gilbert wrote: > James Bottomley wrote: > > On Thu, 2007-07-05 at 14:06 -0700, Kristen Carlson Accardi wrote: > >> Since gendisk will now become part of struct scsi_device, we don't need > >> to store this value in any private data structs where they alrea

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-06 Thread Douglas Gilbert
James Bottomley wrote: > On Thu, 2007-07-05 at 14:06 -0700, Kristen Carlson Accardi wrote: >> Since gendisk will now become part of struct scsi_device, we don't need >> to store this value in any private data structs where they already store >> scsi_device. This series cleans up a few drivers whic

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-06 Thread James Bottomley
On Thu, 2007-07-05 at 14:06 -0700, Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. Actually, as Al

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread James Bottomley
On Fri, 2007-07-06 at 00:02 +0100, Al Viro wrote: > On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote: > > Since gendisk will now become part of struct scsi_device, we don't need > > to store this value in any private data structs where they already store > > scsi_device. Thi

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Al Viro
On Thu, Jul 05, 2007 at 06:09:27PM -0400, Douglas Gilbert wrote: > Since a scsi_device object is usually a SCSI logical unit, > one wonders why it would contain a gendisk object. Logical > units aren't necessarily disks, they might be enclosures or > just place holders that respond to an INQUIRY (e

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Al Viro
On Thu, Jul 05, 2007 at 02:06:36PM -0700, Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. What the

Re: [patch 0/3] clean gendisk out of scsi ULD structs

2007-07-05 Thread Douglas Gilbert
Kristen Carlson Accardi wrote: > Since gendisk will now become part of struct scsi_device, we don't need > to store this value in any private data structs where they already store > scsi_device. This series cleans up a few drivers which did this. Since a scsi_device object is usually a SCSI logic