Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-16 Thread Heikki Orsila
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: > This is my commit message for the revert - note the suggested possible > fix (but also why I didn't apply it, and why things got reverted). > > Linus > --- > commit 279e1dab949d33737557babfe9f74e0b74fbe39a > Author:

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-16 Thread Heikki Orsila
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: This is my commit message for the revert - note the suggested possible fix (but also why I didn't apply it, and why things got reverted). Linus --- commit 279e1dab949d33737557babfe9f74e0b74fbe39a Author: Linus

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Heikki Orsila
On Thu, Nov 15, 2007 at 08:27:25AM -0800, Stephen Hemminger wrote: > I can't reproduce the users problem with the hardware I have. And > without the patch the dual > port board doesn't work. So it is a question of regression, versus > fixing pre-existing bugs. > I am okay with reverting the

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Greg KH
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: > > > On Thu, 15 Nov 2007, Greg KH wrote: > > > On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > > > > > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > > > > > This one is getting reverted

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Thu, 15 Nov 2007, Stephen Hemminger wrote: > > I can't reproduce the users problem with the hardware I have. And > without the patch the dual port board doesn't work. So it is a question > of regression, versus fixing pre-existing bugs. Yeah. Five years ago I might have said that it's

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Thu, 15 Nov 2007, Greg KH wrote: > On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > > > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > > > This one is getting reverted in mainline in about five minutes (unless I > > find an email from Stephen to

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Greg KH
On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: > > > On Wed, 14 Nov 2007, Greg KH wrote: > > > > -stable review patch. If anyone has any objections, please let us know. > > > > -- > > From: Stephen Hemminger <[EMAIL PROTECTED]> > > > > patch

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Stephen Hemminger
Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger <[EMAIL PROTECTED]> patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Wed, 14 Nov 2007, Greg KH wrote: > > -stable review patch. If anyone has any objections, please let us know. > > -- > From: Stephen Hemminger <[EMAIL PROTECTED]> > > patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. > > This fixes problems with transmit hangs on

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Thu, 15 Nov 2007, Greg KH wrote: On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This one is getting reverted in mainline in about five minutes (unless I find an email from Stephen to address the

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Stephen Hemminger
Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This fixes problems with transmit hangs on older

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Greg KH
On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: On Wed, 14 Nov 2007, Greg KH wrote: -stable review patch. If anyone has any objections, please let us know. -- From: Stephen Hemminger [EMAIL PROTECTED] patch

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Linus Torvalds
On Thu, 15 Nov 2007, Stephen Hemminger wrote: I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. Yeah. Five years ago I might have said that it's

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Greg KH
On Thu, Nov 15, 2007 at 08:48:58AM -0800, Linus Torvalds wrote: On Thu, 15 Nov 2007, Greg KH wrote: On Thu, Nov 15, 2007 at 08:11:30AM -0800, Linus Torvalds wrote: patch 7fb7ac241162dc51ec0f7644d4a97b2855213c32 in mainline. This one is getting reverted in mainline in about

Re: [patch 08/16] skge: fix ram buffer size calculation

2007-11-15 Thread Heikki Orsila
On Thu, Nov 15, 2007 at 08:27:25AM -0800, Stephen Hemminger wrote: I can't reproduce the users problem with the hardware I have. And without the patch the dual port board doesn't work. So it is a question of regression, versus fixing pre-existing bugs. I am okay with reverting the patch, as