Re: [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver

2007-06-15 Thread Geert Uytterhoeven
On Fri, 15 Jun 2007, Benjamin Herrenschmidt wrote: > On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (ps3-stable) > > Preallocate 256 KiB of bootmem memory for the PS3 FLASH ROM storage driver. > > I still very much dislike the #ifdef xxx_MODULE in m

Re: [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver

2007-06-15 Thread Benjamin Herrenschmidt
On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote: > plain text document attachment (ps3-stable) > Preallocate 256 KiB of bootmem memory for the PS3 FLASH ROM storage driver. I still very much dislike the #ifdef xxx_MODULE in main kernel code. At the end of the day, is it realistic to e