Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-24 Thread Nick Piggin
Andrew Morton wrote: On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an opportuni

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:38:01 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Ok and BUILD_BUG_ON really works? Had some bad experiences with it. hm, I don't recall any problems, apart from its very obscure error reporting. But if it breaks, we get an opportunity to fix it ;) - To unsu

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: > On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > On Tue, 19 Jun 2007, Andrew Morton wrote: > > > > > On Mon, 18 Jun 2007 02:58:48 -0700 > > > [EMAIL PROTECTED] wrote: > > > > > > > + BUG_ON(KMALLOC_MI

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Tue, 19 Jun 2007 15:22:36 -0700 (PDT) Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Tue, 19 Jun 2007, Andrew Morton wrote: > > > On Mon, 18 Jun 2007 02:58:48 -0700 > > [EMAIL PROTECTED] wrote: > > > > > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > > > + (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SI

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Christoph Lameter
On Tue, 19 Jun 2007, Andrew Morton wrote: > On Mon, 18 Jun 2007 02:58:48 -0700 > [EMAIL PROTECTED] wrote: > > > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > > + (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); > > BUILD_BUG_ON? > Does not matter. That code is __init. - To unsubscribe from thi

Re: [patch 10/26] SLUB: Faster more efficient slab determination for __kmalloc.

2007-06-19 Thread Andrew Morton
On Mon, 18 Jun 2007 02:58:48 -0700 [EMAIL PROTECTED] wrote: > + BUG_ON(KMALLOC_MIN_SIZE > 256 || > + (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1))); BUILD_BUG_ON? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED]