Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Mark Fasheh
On Thu, Mar 15, 2007 at 04:06:39PM -0400, Trond Myklebust wrote: > Hell no! Struct file carries information that is essential for those of > us that use strong authentication. It stays. Joel pointed this out yesterday for the nfs case. Not to worry, we'll keep struct file around :) --Mark

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Trond Myklebust
On Wed, 2007-03-14 at 21:13 -0700, Mark Fasheh wrote: > Hi Nick, > > On Wed, Mar 14, 2007 at 02:38:22PM +0100, Nick Piggin wrote: > > Introduce write_begin, write_end, and perform_write aops. > > > > These are intended to replace prepare_write and commit_write with more > > flexible alternatives

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Steven Whitehouse
Hi, On Thu, 2007-03-15 at 05:36 +0100, Nick Piggin wrote: > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: [some comments snipped] > > Attached is a quick patch to hook up the existing ocfs2 write code. This has > > been compile tested only for now - one of my test machines isn't > >

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Nick Piggin
Dmitriy Monakhov wrote: Nick Piggin <[EMAIL PROTECTED]> writes: Index: linux-2.6/fs/splice.c === --- linux-2.6.orig/fs/splice.c +++ linux-2.6/fs/splice.c @@ -559,7 +559,7 @@ static int pipe_to_file(struct pipe_inod struct

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Dmitriy Monakhov
Nick Piggin <[EMAIL PROTECTED]> writes: > Index: linux-2.6/fs/splice.c > === > --- linux-2.6.orig/fs/splice.c > +++ linux-2.6/fs/splice.c > @@ -559,7 +559,7 @@ static int pipe_to_file(struct pipe_inod > struct address_space *map

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-15 Thread Nick Piggin
On Wed, Mar 14, 2007 at 11:23:05PM -0700, Joel Becker wrote: > On Thu, Mar 15, 2007 at 05:36:42AM +0100, Nick Piggin wrote: > > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: > > > Are we going to get rid of the file and intr arguments btw? I'm not sure > > > intr is useful, and mappi

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Joel Becker
On Thu, Mar 15, 2007 at 05:36:42AM +0100, Nick Piggin wrote: > On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: > > Are we going to get rid of the file and intr arguments btw? I'm not sure > > intr is useful, and mapping is probably enough to get whatever we inside > > ->write_begin / -

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Mark Fasheh
On Thu, Mar 15, 2007 at 05:36:42AM +0100, Nick Piggin wrote: > > Are we going to get rid of the file and intr arguments btw? I'm not sure > > intr is useful, and mapping is probably enough to get whatever we inside > > ->write_begin / ->write_end. > > Yeah, I was going to, but I had this version r

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Nick Piggin
On Wed, Mar 14, 2007 at 09:13:29PM -0700, Mark Fasheh wrote: > Hi Nick, > > On Wed, Mar 14, 2007 at 02:38:22PM +0100, Nick Piggin wrote: > > Introduce write_begin, write_end, and perform_write aops. > > > > These are intended to replace prepare_write and commit_write with more > > flexible altern

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Mark Fasheh
Hi Nick, On Wed, Mar 14, 2007 at 02:38:22PM +0100, Nick Piggin wrote: > Introduce write_begin, write_end, and perform_write aops. > > These are intended to replace prepare_write and commit_write with more > flexible alternatives that are also able to avoid the buffered write > deadlock problems e

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Nick Piggin
On Wed, Mar 14, 2007 at 10:46:25PM +0100, Mariusz Kozlowski wrote: > Hello, > > I guess no need to define 'ret' twice here. [...] Hi Mariusz, Thanks, I'll clean that up. Nick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PRO

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Nick Piggin
On Thu, Mar 15, 2007 at 12:28:04AM +0300, Dmitriy Monakhov wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > + > > +int pagecache_write_end(struct file *file, struct address_space *mapping, > > + loff_t pos, unsigned len, unsigned copied, > > +

Re: [patch 2/5] fs: introduce new aops and infrastructure

2007-03-14 Thread Dmitriy Monakhov
Nick Piggin <[EMAIL PROTECTED]> writes: > Introduce write_begin, write_end, and perform_write aops. > > These are intended to replace prepare_write and commit_write with more > flexible alternatives that are also able to avoid the buffered write > deadlock problems efficiently (which prepare_write