Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Evgeniy Polyakov
On Sun, Apr 10, 2005 at 11:51:24PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: > Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > > > On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: > > > I based my listen program on the fclisten.c posted by Kaigai Kohei > > > with

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Andrew Morton
Evgeniy Polyakov <[EMAIL PROTECTED]> wrote: > > On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: > > I based my listen program on the fclisten.c posted by Kaigai Kohei > > with my own modification. Unfortunately i lost my test machine in the > > lab. I will recreate the

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Evgeniy Polyakov
On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: > I based my listen program on the fclisten.c posted by Kaigai Kohei > with my own modification. Unfortunately i lost my test machine in the > lab. I will recreate the listen program Monday. The original listener > did

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Evgeniy Polyakov
On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: I based my listen program on the fclisten.c posted by Kaigai Kohei with my own modification. Unfortunately i lost my test machine in the lab. I will recreate the listen program Monday. The original listener did not

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Andrew Morton
Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: I based my listen program on the fclisten.c posted by Kaigai Kohei with my own modification. Unfortunately i lost my test machine in the lab. I will recreate the listen

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-11 Thread Evgeniy Polyakov
On Sun, Apr 10, 2005 at 11:51:24PM -0700, Andrew Morton ([EMAIL PROTECTED]) wrote: Evgeniy Polyakov [EMAIL PROTECTED] wrote: On Sun, Apr 10, 2005 at 10:43:24PM -0700, Jay Lan ([EMAIL PROTECTED]) wrote: I based my listen program on the fclisten.c posted by Kaigai Kohei with my own

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-10 Thread Jay Lan
I based my listen program on the fclisten.c posted by Kaigai Kohei with my own modification. Unfortunately i lost my test machine in the lab. I will recreate the listen program Monday. The original listener did not validate sequence number. It also prints length of data and sequence number of

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-10 Thread Jay Lan
I based my listen program on the fclisten.c posted by Kaigai Kohei with my own modification. Unfortunately i lost my test machine in the lab. I will recreate the listen program Monday. The original listener did not validate sequence number. It also prints length of data and sequence number of

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-09 Thread Evgeniy Polyakov
On Fri, 08 Apr 2005 20:31:20 -0700 Jay Lan <[EMAIL PROTECTED]> wrote: > With the patch you provide to me, i did not see the bugcheck > at cn_queue_wrapper() at the console. > > Unmatched sequence number messages still happened. We expect > to lose packets under system stressed situation, but i

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-09 Thread Evgeniy Polyakov
On Fri, 08 Apr 2005 20:31:20 -0700 Jay Lan [EMAIL PROTECTED] wrote: With the patch you provide to me, i did not see the bugcheck at cn_queue_wrapper() at the console. Unmatched sequence number messages still happened. We expect to lose packets under system stressed situation, but i still

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
With the patch you provide to me, i did not see the bugcheck at cn_queue_wrapper() at the console. Unmatched sequence number messages still happened. We expect to lose packets under system stressed situation, but i still observed duplicate messages, which concerned me. Unmatched seq. Rcvd=79477,

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
On Fri, 08 Apr 2005 15:08:13 -0700 Jay Lan <[EMAIL PROTECTED]> wrote: > Hi Evgeniy, > > Forget about my previous request of a new patch. > > The failures were straight forward enough to figure out. Ok. The latest sources are always awailable at http://tservice.net.ru/~s0mbre/archive/connector

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
Hi Evgeniy, Forget about my previous request of a new patch. The failures were straight forward enough to figure out. - jay Jay Lan wrote: My workarea was based on 2.6.12-rc1-mm4 plus Guilluame's patch. Your patch caused 5 out of 8 hunks failure at connector.c and one failure at connector.h. Could

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
My workarea was based on 2.6.12-rc1-mm4 plus Guilluame's patch. Your patch caused 5 out of 8 hunks failure at connector.c and one failure at connector.h. Could you generate a new patch based on my version? A tar file of complete source of drivers/connector would work also. :) Thanks! - jay

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
Could you give attached patch a try instead of previous one. It adds gfp mask into cn_netlink_send() call also. If you need updated CBUS sources, feel free to ask, I will send updated sources with Andrew's comments resolved too. I do not know exactly your connector version, so patch will

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
On Thu, 2005-04-07 at 15:47 -0700, Jay Lan wrote: > BTW, when it happened last time, my program listening to the socket > complained about duplicate messages received. > > Unmatched seq. Rcvd=1824062, expected=1824061 <=== > Unmatched seq. Rcvd=1824062, expected=1824063 <=== >

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
On Thu, 2005-04-07 at 15:47 -0700, Jay Lan wrote: BTW, when it happened last time, my program listening to the socket complained about duplicate messages received. Unmatched seq. Rcvd=1824062, expected=1824061 === Unmatched seq. Rcvd=1824062, expected=1824063 === Unmatched

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
Could you give attached patch a try instead of previous one. It adds gfp mask into cn_netlink_send() call also. If you need updated CBUS sources, feel free to ask, I will send updated sources with Andrew's comments resolved too. I do not know exactly your connector version, so patch will

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
My workarea was based on 2.6.12-rc1-mm4 plus Guilluame's patch. Your patch caused 5 out of 8 hunks failure at connector.c and one failure at connector.h. Could you generate a new patch based on my version? A tar file of complete source of drivers/connector would work also. :) Thanks! - jay

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
Hi Evgeniy, Forget about my previous request of a new patch. The failures were straight forward enough to figure out. - jay Jay Lan wrote: My workarea was based on 2.6.12-rc1-mm4 plus Guilluame's patch. Your patch caused 5 out of 8 hunks failure at connector.c and one failure at connector.h. Could

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Evgeniy Polyakov
On Fri, 08 Apr 2005 15:08:13 -0700 Jay Lan [EMAIL PROTECTED] wrote: Hi Evgeniy, Forget about my previous request of a new patch. The failures were straight forward enough to figure out. Ok. The latest sources are always awailable at http://tservice.net.ru/~s0mbre/archive/connector - jay

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-08 Thread Jay Lan
With the patch you provide to me, i did not see the bugcheck at cn_queue_wrapper() at the console. Unmatched sequence number messages still happened. We expect to lose packets under system stressed situation, but i still observed duplicate messages, which concerned me. Unmatched seq. Rcvd=79477,

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-07 Thread Jay Lan
BTW, when it happened last time, my program listening to the socket complained about duplicate messages received. Unmatched seq. Rcvd=1824062, expected=1824061 <=== Unmatched seq. Rcvd=1824062, expected=1824063 <=== Unmatched seq. Rcvd=1824348, expected=1824307 When my program

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-07 Thread Jay Lan
Hi Evgeniy, Should i be concerned about this bugcheck? I have seen this happening a number of times, all with the same signature in my testing. I ran a mix of AIM7, ubench, fork-test (continuously fork new processes), and another program reading from the fork connector socket. Thanks, - jay

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-07 Thread Jay Lan
Hi Evgeniy, Should i be concerned about this bugcheck? I have seen this happening a number of times, all with the same signature in my testing. I ran a mix of AIM7, ubench, fork-test (continuously fork new processes), and another program reading from the fork connector socket. Thanks, - jay

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-07 Thread Jay Lan
BTW, when it happened last time, my program listening to the socket complained about duplicate messages received. Unmatched seq. Rcvd=1824062, expected=1824061 === Unmatched seq. Rcvd=1824062, expected=1824063 === Unmatched seq. Rcvd=1824348, expected=1824307 When my program received

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-01 Thread Guillaume Thouvenin
ChangeLog: - Remove unnecessary catch in cn_fork_callback(). - Use reverse dependencies in Kconfig. By doing this, if fork connector is enabled, the connector will be automatically selected as built-in. It's the what we need. - Move the cn_fork_enable and cb_fork_id declarations

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-04-01 Thread Guillaume Thouvenin
ChangeLog: - Remove unnecessary catch in cn_fork_callback(). - Use reverse dependencies in Kconfig. By doing this, if fork connector is enabled, the connector will be automatically selected as built-in. It's the what we need. - Move the cn_fork_enable and cb_fork_id declarations

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Evgeniy Polyakov
On Thu, 2005-03-31 at 16:10 -0800, Jay Lan wrote: > Andrew Morton wrote: > > >Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > > > > > >> This patch adds a fork connector in the do_fork() routine. > >>... > >> > >> The fork connector is used by the Enhanced Linux System Accounting > >>project

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Jay Lan
Andrew Morton wrote: Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: This patch adds a fork connector in the do_fork() routine. ... The fork connector is used by the Enhanced Linux System Accounting project http://elsa.sourceforge.net Does it also meet all the in-kernel requirements for

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Andrew Morton
Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > > This patch adds a fork connector in the do_fork() routine. > > +config FORK_CONNECTOR > + bool "Enable fork connector" > + depends on CONNECTOR=y This kind of defeats connector's ability to be built as a module. Doing

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Andrew Morton
Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > > This patch adds a fork connector in the do_fork() routine. > ... > > The fork connector is used by the Enhanced Linux System Accounting > project http://elsa.sourceforge.net Does it also meet all the in-kernel requirements for other

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Andrew Morton
Guillaume Thouvenin [EMAIL PROTECTED] wrote: This patch adds a fork connector in the do_fork() routine. ... The fork connector is used by the Enhanced Linux System Accounting project http://elsa.sourceforge.net Does it also meet all the in-kernel requirements for other accounting

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Andrew Morton
Guillaume Thouvenin [EMAIL PROTECTED] wrote: This patch adds a fork connector in the do_fork() routine. +config FORK_CONNECTOR + bool Enable fork connector + depends on CONNECTOR=y This kind of defeats connector's ability to be built as a module. Doing select

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Jay Lan
Andrew Morton wrote: Guillaume Thouvenin [EMAIL PROTECTED] wrote: This patch adds a fork connector in the do_fork() routine. ... The fork connector is used by the Enhanced Linux System Accounting project http://elsa.sourceforge.net Does it also meet all the in-kernel requirements for

Re: [patch 2.6.12-rc1-mm4] fork_connector: add a fork connector

2005-03-31 Thread Evgeniy Polyakov
On Thu, 2005-03-31 at 16:10 -0800, Jay Lan wrote: Andrew Morton wrote: Guillaume Thouvenin [EMAIL PROTECTED] wrote: This patch adds a fork connector in the do_fork() routine. ... The fork connector is used by the Enhanced Linux System Accounting project