Re: [patch 3/3] mm: fix PageUptodate memorder

2007-02-25 Thread Nick Piggin
On Sun, Feb 25, 2007 at 04:06:57AM -0800, Andrew Morton wrote: > > What an unpleasing patchset. I really really hope we really have a bug in > there, and that all this crap isn't pointless uglification. It's the same bug for file pages as we had for anonymous pages, which the POWER guys actually

Re: [patch 3/3] mm: fix PageUptodate memorder

2007-02-25 Thread Andrew Morton
What an unpleasing patchset. I really really hope we really have a bug in there, and that all this crap isn't pointless uglification. We _do_ need a flush_dcaceh_page() in all cases which you're concerned about. Perhaps we should stick the appropriate barriers in there. > On Thu, 15 Feb 2007 0