Re: [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps

2008-01-29 Thread Christoph Lameter
Thanks I will put that into V3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps

2008-01-29 Thread Andrea Arcangeli
This should fix the aging bugs you introduced through the faulty cpp expansion. This is hard to write for me, given any time somebody does a ptep_clear_flush_young w/o manually cpp-expandin "| mmu_notifier_age_page" after it, it's always a bug that needs fixing, similar bugs can emerge with time fo

Re: [patch 4/6] MMU notifier: invalidate_page callbacks using Linux rmaps

2008-01-29 Thread Andrea Arcangeli
On Mon, Jan 28, 2008 at 12:28:44PM -0800, Christoph Lameter wrote: > if (!migration && ((vma->vm_flags & VM_LOCKED) || > - (ptep_clear_flush_young(vma, address, pte { > + (ptep_clear_flush_young(vma, address, pte) || > +