Re: [patch 5/5] Disallow in-inode attributes for reserved inodes

2005-01-20 Thread Andreas Gruenbacher
On Friday 21 January 2005 00:05, Andreas Dilger wrote: > [...] > But as your patch stands it doesn't ever check if i_extra_isize is valid > for the root or lost+found inode. It just always sets i_extra_isize = 0 (that's the in-memory i_extra_isize) > and never uses it. Given that the root

Re: [patch 5/5] Disallow in-inode attributes for reserved inodes

2005-01-20 Thread Andreas Dilger
On Jan 20, 2005 14:29 +0100, Andreas Gruenbacher wrote: > The ea-in-inode patch totally relies on getting all the available inode space > cleared out by the kernel (or mke2fs, or e2fsck). If this is not the case for > any inode we find, then i_extra_isize may contain a random number, and we've

Re: [patch 5/5] Disallow in-inode attributes for reserved inodes

2005-01-20 Thread Andreas Gruenbacher
On Thursday 20 January 2005 13:16, Andreas Dilger wrote: > On Jan 20, 2005 03:01 +0100, Andreas Gruenbacher wrote: > > When creating a filesystem with inodes bigger than 128 bytes, mke2fs > > fails to clear out bytes beyond EXT3_GOOD_OLD_INODE_SIZE in all inodes > > it creates (the journal, the fi

Re: [patch 5/5] Disallow in-inode attributes for reserved inodes

2005-01-20 Thread Andreas Dilger
On Jan 20, 2005 03:01 +0100, Andreas Gruenbacher wrote: > When creating a filesystem with inodes bigger than 128 bytes, mke2fs > fails to clear out bytes beyond EXT3_GOOD_OLD_INODE_SIZE in all inodes > it creates (the journal, the filesystem root, and lost+found). We would > require a zeroed-out i