Re: [patch 6/9] mm + fs: store shadow entries in page cache

2014-01-12 Thread Minchan Kim
On Fri, Jan 10, 2014 at 01:10:40PM -0500, Johannes Weiner wrote: > Reclaim will be leaving shadow entries in the page cache radix tree > upon evicting the real page. As those pages are found from the LRU, > an iput() can lead to the inode being freed concurrently. At this > point, reclaim must no

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2014-01-10 Thread Rik van Riel
On 01/10/2014 01:10 PM, Johannes Weiner wrote: > Reclaim will be leaving shadow entries in the page cache radix tree > upon evicting the real page. As those pages are found from the LRU, > an iput() can lead to the inode being freed concurrently. At this > point, reclaim must no longer install sh

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2013-11-27 Thread Dave Chinner
On Wed, Nov 27, 2013 at 12:08:04PM -0500, Johannes Weiner wrote: > On Tue, Nov 26, 2013 at 10:17:16AM +1100, Dave Chinner wrote: > > On Sun, Nov 24, 2013 at 06:38:25PM -0500, Johannes Weiner wrote: > > > Reclaim will be leaving shadow entries in the page cache radix tree > > > upon evicting the rea

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2013-11-27 Thread Johannes Weiner
On Tue, Nov 26, 2013 at 10:17:16AM +1100, Dave Chinner wrote: > On Sun, Nov 24, 2013 at 06:38:25PM -0500, Johannes Weiner wrote: > > Reclaim will be leaving shadow entries in the page cache radix tree > > upon evicting the real page. As those pages are found from the LRU, > > an iput() can lead to

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2013-11-27 Thread Johannes Weiner
On Tue, Nov 26, 2013 at 11:20:53AM +0100, Peter Zijlstra wrote: > On Tue, Nov 26, 2013 at 10:17:16AM +1100, Dave Chinner wrote: > > void truncate_inode_pages_final(struct address_space *mapping) > > { > > mapping_set_exiting(mapping); > > if (inode->i_data.nrpages || inode->i_data.nrshadows

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2013-11-26 Thread Peter Zijlstra
On Tue, Nov 26, 2013 at 10:17:16AM +1100, Dave Chinner wrote: > void truncate_inode_pages_final(struct address_space *mapping) > { > mapping_set_exiting(mapping); > if (inode->i_data.nrpages || inode->i_data.nrshadows) { > /* >* spinlock barrier to ensure a

Re: [patch 6/9] mm + fs: store shadow entries in page cache

2013-11-25 Thread Dave Chinner
On Sun, Nov 24, 2013 at 06:38:25PM -0500, Johannes Weiner wrote: > Reclaim will be leaving shadow entries in the page cache radix tree > upon evicting the real page. As those pages are found from the LRU, > an iput() can lead to the inode being freed concurrently. At this > point, reclaim must no