Re: [patch 7/12] s390: fba dasd i/o errors.

2005-07-12 Thread Denis Vlasenko
On Tuesday 12 July 2005 13:36, Martin Schwidefsky wrote: > > > @@ -354,6 +354,8 @@ dasd_fba_build_cp(struct dasd_device * d > > > } > > > cqr->device = device; > > > cqr->expires = 5 * 60 * HZ; /* 5 minutes */ > > > +cqr->retries = 32; > > > > 2..4 maybe,

Re: [patch 7/12] s390: fba dasd i/o errors.

2005-07-12 Thread Martin Schwidefsky
> > @@ -354,6 +354,8 @@ dasd_fba_build_cp(struct dasd_device * d > > } > > cqr->device = device; > > cqr->expires = 5 * 60 * HZ; /* 5 minutes */ > > +cqr->retries = 32; > > 2..4 maybe, but 32? This isn't tiny by any account. Are you arguing the use of the

Re: [patch 7/12] s390: fba dasd i/o errors.

2005-07-12 Thread Denis Vlasenko
On Monday 11 July 2005 19:36, Martin Schwidefsky wrote: > [patch 7/12] s390: fba dasd i/o errors. > > From: Horst Hummel <[EMAIL PROTECTED]> > > The FBA discipline does not use retries for failed requests. A request > fails after the first unsuccessful start attempt. There are some rare > conditi