Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-09 Thread Jarkko Sakkinen
On Tue, Oct 07, 2014 at 04:34:42PM -0600, Jason Gunthorpe wrote: > On Wed, Oct 08, 2014 at 01:28:14AM +0300, Jarkko Sakkinen wrote: > > > > > @@ -714,15 +709,10 @@ static int tpm_tis_i2c_remove(struct i2c_client > > > > *client) > > > > struct tpm_chip *chip = tpm_dev.chip; > > > >

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jason Gunthorpe
On Wed, Oct 08, 2014 at 01:28:14AM +0300, Jarkko Sakkinen wrote: > > > @@ -714,15 +709,10 @@ static int tpm_tis_i2c_remove(struct i2c_client > > > *client) > > > struct tpm_chip *chip = tpm_dev.chip; > > > release_locality(chip, chip->vendor.locality, 1); > > > > > > - /* close file handles

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jarkko Sakkinen
On Tue, Oct 07, 2014 at 11:50:17AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 07, 2014 at 08:01:12PM +0300, Jarkko Sakkinen wrote: > > Added tpm_chip_alloc() and tpm_chip_register() where tpm_chip_alloc() > > reserves memory resources and tpm_chip_register() initializes the > > device driver. This

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jarkko Sakkinen
On Tue, Oct 07, 2014 at 12:27:56PM -0600, Jason Gunthorpe wrote: > On Tue, Oct 07, 2014 at 09:04:17PM +0300, Jarkko Sakkinen wrote: > > > > Did you test compile all the drivers? One of my git commits on github > > > has some hackery to make that possible on x86. > > > > Yeah, I compiled all the d

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jason Gunthorpe
On Tue, Oct 07, 2014 at 09:04:17PM +0300, Jarkko Sakkinen wrote: > > Did you test compile all the drivers? One of my git commits on github > > has some hackery to make that possible on x86. > > Yeah, I compiled all the drivers: > > $ grep CONFIG_TCG .config > CONFIG_TCG_TPM=m > CONFIG_TCG_TIS=m

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jarkko Sakkinen
Hi And thanks for the feedback. Change requests look very reasonable. On Tue, Oct 07, 2014 at 11:50:17AM -0600, Jason Gunthorpe wrote: > On Tue, Oct 07, 2014 at 08:01:12PM +0300, Jarkko Sakkinen wrote: > > Added tpm_chip_alloc() and tpm_chip_register() where tpm_chip_alloc() > > reserves memory r

Re: [tpmdd-devel] [PATCH v2 2/7] tpm: two-phase chip management functions

2014-10-07 Thread Jason Gunthorpe
On Tue, Oct 07, 2014 at 08:01:12PM +0300, Jarkko Sakkinen wrote: > Added tpm_chip_alloc() and tpm_chip_register() where tpm_chip_alloc() > reserves memory resources and tpm_chip_register() initializes the > device driver. This way it is possible to alter struct tpm_chip > attributes before passing