Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 09:57:58AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > I can't conveniently build it, so I'm sure I've broken things. I > > Indeed, you have :) > > > pushed the current work-in-progress branch to pci/host-rockchip-wip.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 09:57:58AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > I can't conveniently build it, so I'm sure I've broken things. I > > Indeed, you have :) > > > pushed the current work-in-progress branch to pci/host-rockchip-wip.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Am Freitag, 2. September 2016, 10:44:09 schrieb Bjorn Helgaas: > On Thu, Sep 01, 2016 at 12:48:52PM -0500, Bjorn Helgaas wrote: > > On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > > > The use of HIWORD_UPDATE can indeed be a bit confusing, IMO, but this is > > > really a common

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Am Freitag, 2. September 2016, 10:44:09 schrieb Bjorn Helgaas: > On Thu, Sep 01, 2016 at 12:48:52PM -0500, Bjorn Helgaas wrote: > > On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > > > The use of HIWORD_UPDATE can indeed be a bit confusing, IMO, but this is > > > really a common

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 12:48:52PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > > The use of HIWORD_UPDATE can indeed be a bit confusing, IMO, but this is > > really a common Rockchip-ism that, once you read several of their > > drivers, can make a

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 12:48:52PM -0500, Bjorn Helgaas wrote: > On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > > The use of HIWORD_UPDATE can indeed be a bit confusing, IMO, but this is > > really a common Rockchip-ism that, once you read several of their > > drivers, can make a

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > I can't conveniently build it, so I'm sure I've broken things. I Indeed, you have :) > pushed the current work-in-progress branch to pci/host-rockchip-wip. > After we fix build errors and other thinkos, I'll rename it and put it >

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > I can't conveniently build it, so I'm sure I've broken things. I Indeed, you have :) > pushed the current work-in-progress branch to pci/host-rockchip-wip. > After we fix build errors and other thinkos, I'll rename it and put it >

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > In the interest of making progress, I made most of the changes Guenter > > suggested (thanks very much, Guenter!) and made some more of my own on > > top of those. >

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 10:14:01AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > In the interest of making progress, I made most of the changes Guenter > > suggested (thanks very much, Guenter!) and made some more of my own on > > top of those. >

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > In the interest of making progress, I made most of the changes Guenter > suggested (thanks very much, Guenter!) and made some more of my own on > top of those. I'm not sure, but was this change your idea Bjorn? commit

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > In the interest of making progress, I made most of the changes Guenter > suggested (thanks very much, Guenter!) and made some more of my own on > top of those. I'm not sure, but was this change your idea Bjorn? commit

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Am Donnerstag, 1. September 2016, 10:14:01 schrieb Brian Norris: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > In the interest of making progress, I made most of the changes Guenter > > suggested (thanks very much, Guenter!) and made some more of my own on > > top of those.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Am Donnerstag, 1. September 2016, 10:14:01 schrieb Brian Norris: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > In the interest of making progress, I made most of the changes Guenter > > suggested (thanks very much, Guenter!) and made some more of my own on > > top of those.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 09:57:58AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > I can't conveniently build it, so I'm sure I've broken things. I > > Indeed, you have :) > > > pushed the current work-in-progress branch to pci/host-rockchip-wip.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 09:57:58AM -0700, Brian Norris wrote: > On Thu, Sep 01, 2016 at 11:34:55AM -0500, Bjorn Helgaas wrote: > > I can't conveniently build it, so I'm sure I've broken things. I > > Indeed, you have :) > > > pushed the current work-in-progress branch to pci/host-rockchip-wip.

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:39:41AM +0800, Shawn Lin wrote: > Hi Guenter, > > Thanks for your review, and I think it still not too late > for nitpicking as it isn't merged to next branch. :) > > We have amend the code a bit, so probably we fixed some of > the minor issues against V10. But some of

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Thu, Sep 01, 2016 at 11:39:41AM +0800, Shawn Lin wrote: > Hi Guenter, > > Thanks for your review, and I think it still not too late > for nitpicking as it isn't merged to next branch. :) > > We have amend the code a bit, so probably we fixed some of > the minor issues against V10. But some of

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On 08/31/2016 08:39 PM, Shawn Lin wrote: Hi Guenter, Thanks for your review, and I think it still not too late for nitpicking as it isn't merged to next branch. :) We have amend the code a bit, so probably we fixed some of the minor issues against V10. But some of them are really personal

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On 08/31/2016 08:39 PM, Shawn Lin wrote: Hi Guenter, Thanks for your review, and I think it still not too late for nitpicking as it isn't merged to next branch. :) We have amend the code a bit, so probably we fixed some of the minor issues against V10. But some of them are really personal

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Hi Guenter, Thanks for your review, and I think it still not too late for nitpicking as it isn't merged to next branch. :) We have amend the code a bit, so probably we fixed some of the minor issues against V10. But some of them are really personal taste, if you still insist on that, I will be

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

Hi Guenter, Thanks for your review, and I think it still not too late for nitpicking as it isn't merged to next branch. :) We have amend the code a bit, so probably we fixed some of the minor issues against V10. But some of them are really personal taste, if you still insist on that, I will be

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Fri, Aug 19, 2016 at 09:34:58AM +0800, Shawn Lin wrote: > This patch adds Rockchip PCIe controller support found > on RK3399 Soc platform. > > Signed-off-by: Shawn Lin > > Reviewed-by: Brian Norris > --- > > Changes in v10: > - remove

Re: [v10,2/2] PCI: Rockchip: Add Rockchip PCIe controller support

On Fri, Aug 19, 2016 at 09:34:58AM +0800, Shawn Lin wrote: > This patch adds Rockchip PCIe controller support found > on RK3399 Soc platform. > > Signed-off-by: Shawn Lin > > Reviewed-by: Brian Norris > --- > > Changes in v10: > - remove ARM64 dependencies from Kconfig > > Changes in v9: > -