Re: [v2 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-28 Thread John Hubbard
On 1/28/19 12:06 PM, Yang Shi wrote: > Hi John, > > Sorry for the late reply. It seems your email didn't reach my company > mailbox. So, I replied you with my personal email. > > Thanks for your suggestion. This does make the code looks neater. > However, I'm not sure how Andrew thought about thi

Re: [v2 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-28 Thread Yang Shi
Hi John, Sorry for the late reply. It seems your email didn't reach my company mailbox. So, I replied you with my personal email. Thanks for your suggestion. This does make the code looks neater. However, I'm not sure how Andrew thought about this patch. Once he is ok to this patch in overall, I

Re: [v2 PATCH] mm: ksm: do not block on page lock when searching stable tree

2019-01-23 Thread John Hubbard
On 1/23/19 3:52 PM, Yang Shi wrote: > ksmd need search stable tree to look for the suitable KSM page, but the > KSM page might be locked for a while due to i.e. KSM page rmap walk. > Basically it is not a big deal since commit 2c653d0ee2ae > ("ksm: introduce ksm_max_page_sharing per page deduplicat