RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-12 Thread Chin-Ting Kuo
Hi Vignesh, Thanks for your information. > -Original Message- > From: Vignesh Raghavendra > Sent: Wednesday, November 11, 2020 1:44 PM > To: Chin-Ting Kuo ; Boris Brezillon > > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver >

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-10 Thread Vignesh Raghavendra
Hi Chin-Ting, On 11/6/20 11:57 PM, Chin-Ting Kuo wrote: > Hi Boris, > >> -Original Message- >> From: Boris Brezillon >> Sent: Friday, November 6, 2020 7:30 PM >> To: Chin-Ting Kuo >> Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory c

RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Chin-Ting Kuo
Hi Boris, > -Original Message- > From: Boris Brezillon > Sent: Friday, November 6, 2020 7:30 PM > To: Chin-Ting Kuo > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver > > +Tudor and Vignesh > > On Fri, 6 Nov 2020 10:21:0

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Boris Brezillon
.org; j...@jms.id.au; and...@aj.id.au; > > > > bbrezil...@kernel.org; devicet...@vger.kernel.org; > > > > linux-kernel@vger.kernel.org; linux-asp...@lists.ozlabs.org; > > > > linux-...@vger.kernel.org; BMC-SW > > > > Subject: Re: [v3 4/4] spi: aspeed: Add AS

RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Chin-Ting Kuo
Hi Boris, Thanks for your comments and suggestions. > -Original Message- > From: Boris Brezillon > Sent: Friday, November 6, 2020 5:06 PM > To: Chin-Ting Kuo > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver > > On Fri, 6 Nov 20

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Boris Brezillon
gt; Cc: Chin-Ting Kuo ; broo...@kernel.org; > > j...@jms.id.au; and...@aj.id.au; bbrezil...@kernel.org; > > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > > linux-asp...@lists.ozlabs.org; linux-...@vger.kernel.org; BMC-SW > > > > Subject: Re: [v3 4/4]

RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Chin-Ting Kuo
Hi Mark, > -Original Message- > From: Mark Brown > Sent: Friday, November 6, 2020 12:43 AM > To: Boris Brezillon > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver > > On Thu, Nov 05, 2020 at 04:11:32PM +0100, Boris Brezillon wro

RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-06 Thread Chin-Ting Kuo
nel.org; > devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-asp...@lists.ozlabs.org; linux-...@vger.kernel.org; BMC-SW > > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver > > Hi, > > On Thu, 5 Nov 2020 15:09:11 +0100 >

RE: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-05 Thread Chin-Ting Kuo
.org; linux-kernel@vger.kernel.org; > linux-asp...@lists.ozlabs.org; linux-...@vger.kernel.org > Cc: BMC-SW > Subject: Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller > driver > > Hello Chin-Ting, > > Thanks for this driver. It's much cleaner than the prev

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-05 Thread Mark Brown
On Thu, Nov 05, 2020 at 04:11:32PM +0100, Boris Brezillon wrote: > Cédric Le Goater wrote: > > Thanks for this driver. It's much cleaner than the previous and we should > > try adding support for the AST2500 SoC also. I guess we can keep the old > > driver for the AST2400 which has a different

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-05 Thread Boris Brezillon
Hi, On Thu, 5 Nov 2020 15:09:11 +0100 Cédric Le Goater wrote: > Hello Chin-Ting, > > Thanks for this driver. It's much cleaner than the previous and we should > try adding support for the AST2500 SoC also. I guess we can keep the old > driver for the AST2400 which has a different register lay

Re: [v3 4/4] spi: aspeed: Add ASPEED FMC/SPI memory controller driver

2020-11-05 Thread Cédric Le Goater
Hello Chin-Ting, Thanks for this driver. It's much cleaner than the previous and we should try adding support for the AST2500 SoC also. I guess we can keep the old driver for the AST2400 which has a different register layout. On the patchset, I think we should split this patch in three : - b