Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-26 Thread Robert Love
On Fri, 2005-08-26 at 13:52 -0400, John McCutchan wrote: > Thanks for your suggestion, it has fixed the inotify problem. But where > to put the fix is turning into a bit of a mess. Some callers like > drivers/md/dm.c:682 call idr_get_new_above as if it will return >= > starting_id. The comment say

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-26 Thread John McCutchan
On Fri, 2005-08-26 at 13:03 -0400, Jim Houston wrote: > Hi Everyone, > > I'm answering this from my home email. I have not heard from my > co-workers in Florida yet, and I imagine that they are busy cleaning up > after hurricane Katrina and waiting for the power to come back on. > > It looks like

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-26 Thread Jim Houston
Hi Everyone, I'm answering this from my home email. I have not heard from my co-workers in Florida yet, and I imagine that they are busy cleaning up after hurricane Katrina and waiting for the power to come back on. It looks like we have an "off by one" problem with idr_get_new_above() which may

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 16:10 -0700, George Anzinger wrote: > That IS strange. 1024 is on a "level" boundry, but then next level is > 2**15, not 2**11. I will take a look. Remember that the level is never filled, so maybe the smallest level just gets an offset or something? Well, you're the expe

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread George Anzinger
John McCutchan wrote: On Thu, 2005-08-25 at 11:54 -0700, George Anzinger wrote: Robert Love wrote: On Thu, 2005-08-25 at 09:33 -0400, John McCutchan wrote: On Thu, 2005-08-25 at 22:07 +1200, Reuben Farrelly wrote: ~ I think the best thing is to take idr into user space and emulate the pr

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 11:54 -0700, George Anzinger wrote: > I think the best thing is to take idr into user space and emulate the > problem usage. Good plan, I guess. Do you think that's easy? > To this end, from the log it appears that you _might_ be > moving between 0, 1 and 2 entries incr

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 21:03 +0200, Johannes Berg wrote: > On Thu, 2005-08-25 at 11:54 -0700, George Anzinger wrote: > > > I think the best thing is to take idr into user space and emulate the > > problem usage. > > Good plan, I guess. Do you think that's easy? > > > To this end, from the log

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 11:54 -0700, George Anzinger wrote: > Robert Love wrote: > > On Thu, 2005-08-25 at 09:33 -0400, John McCutchan wrote: > > > >>On Thu, 2005-08-25 at 22:07 +1200, Reuben Farrelly wrote: > >> > ~ > >>>dovecot: Aug 25 19:31:26 Warning: IMAP(gilly): removing wd 1022 from > >>>ino

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread George Anzinger
Robert Love wrote: On Thu, 2005-08-25 at 09:33 -0400, John McCutchan wrote: On Thu, 2005-08-25 at 22:07 +1200, Reuben Farrelly wrote: ~ dovecot: Aug 25 19:31:26 Warning: IMAP(gilly): removing wd 1022 from inotify fd 4 dovecot: Aug 25 19:31:27 Warning: IMAP(gilly): inotify_add_watch returned

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Robert Love
On Thu, 2005-08-25 at 09:33 -0400, John McCutchan wrote: > On Thu, 2005-08-25 at 22:07 +1200, Reuben Farrelly wrote: > > Hi, > > > > I have also observed another problem with inotify with dovecot - so I spoke > > with Johannes Berg who wrote the inotify code in dovecot. He suggested I > > post

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 16:41 +0200, Johannes Berg wrote: > On Thu, 2005-08-25 at 10:13 -0400, John McCutchan wrote: > > > I really don't want 2.6.13 to go out with this bug or the compromise. If > > we use 0, we will have a lot of wd re-use. Which will cause "strange" > > problems in inotify using

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 10:13 -0400, John McCutchan wrote: > I really don't want 2.6.13 to go out with this bug or the compromise. If > we use 0, we will have a lot of wd re-use. Which will cause "strange" > problems in inotify using applications that cleanup upon receipt of an > IN_IGNORE event. W

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 16:13 +0200, Johannes Berg wrote: > On Thu, 2005-08-25 at 10:06 -0400, John McCutchan wrote: > > > it fails on 2.6.13-rc6 as soon as the device is full and doesn't hold > > > any more directories. > > Obviously this wasn't true, I was hitting the 8192 watches limit and > misi

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 10:06 -0400, John McCutchan wrote: > > it fails on 2.6.13-rc6 as soon as the device is full and doesn't hold > > any more directories. Obviously this wasn't true, I was hitting the 8192 watches limit and misinterpreted the error message. I just tested up to 10 watches wit

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 09:47 -0400, Robert Love wrote: > On Thu, 2005-08-25 at 09:40 -0400, John McCutchan wrote: > > > I get that message a lot. I know I have said this before (and was wrong) > > but I think the idr layer is busted. > > This time I think I agree with you. ;-) > > Let's just pas

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 16:03 +0200, Johannes Berg wrote: > On Thu, 2005-08-25 at 09:47 -0400, Robert Love wrote: > > > Let's just pass zero for the "above" parameter in idr_get_new_above(), > > which is I believe the behavior of the other interface, and see if the > > 1024-multiple problem goes awa

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 09:47 -0400, Robert Love wrote: > Let's just pass zero for the "above" parameter in idr_get_new_above(), > which is I believe the behavior of the other interface, and see if the > 1024-multiple problem goes away. We definitely did not have that > before. Will we then need t

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 15:50 +0200, Johannes Berg wrote: > On Thu, 2005-08-25 at 09:40 -0400, John McCutchan wrote: > > > On 2.6.13-rc7 the test program fails. It always fails when a wd == 1024. > > If I skip inotify_rm_watch when wd == 1024, it will fail at wd == 2048. > > It seems the idr layer h

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
On Thu, 2005-08-25 at 09:40 -0400, John McCutchan wrote: > On 2.6.13-rc7 the test program fails. It always fails when a wd == 1024. > If I skip inotify_rm_watch when wd == 1024, it will fail at wd == 2048. > It seems the idr layer has an aversion to multiples of 1024. > > When I run your test pro

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Robert Love
On Thu, 2005-08-25 at 09:40 -0400, John McCutchan wrote: > I get that message a lot. I know I have said this before (and was wrong) > but I think the idr layer is busted. This time I think I agree with you. ;-) Let's just pass zero for the "above" parameter in idr_get_new_above(), which is I be

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 14:18 +0200, Johannes Berg wrote: > Hi, > > > I have also observed another problem with inotify with dovecot - so I spoke > > with Johannes Berg who wrote the inotify code in dovecot. He suggested I > > post > > here to LKML since his opinion is that this to be a kernel b

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread John McCutchan
On Thu, 2005-08-25 at 22:07 +1200, Reuben Farrelly wrote: > Hi, > > I have also observed another problem with inotify with dovecot - so I spoke > with Johannes Berg who wrote the inotify code in dovecot. He suggested I > post > here to LKML since his opinion is that this to be a kernel bug. >

Re: Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Johannes Berg
Hi, > I have also observed another problem with inotify with dovecot - so I spoke > with Johannes Berg who wrote the inotify code in dovecot. He suggested I > post > here to LKML since his opinion is that this to be a kernel bug. Allow me to jump in at this point. The small tool below trigger

Inotify problem [was Re: 2.6.13-rc6-mm1]

2005-08-25 Thread Reuben Farrelly
Hi, On 22/08/2005 9:10 p.m., John McCutchan wrote: On Sat, 2005-08-20 at 23:52 -0700, Andrew Morton wrote: Reuben Farrelly <[EMAIL PROTECTED]> wrote: Hi, On 19/08/2005 11:37 a.m., Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ -

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Rogério Brito
Hi. Unfortunately, it seems that current kernels (including vanilla -rc kernels) don't compile correctly on ppc if I have APM emulation enabled, but PMU disabled (only CUDA enabled). Here is what I get from a compilation try: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Andrew Morton
Rogério Brito <[EMAIL PROTECTED]> wrote: > > Unfortunately, it seems that current kernels (including vanilla -rc > kernels) don't compile correctly on ppc if I have APM emulation enabled, > but PMU disabled (only CUDA enabled). > > Here is what I get from a compilation try: > > - - - - - - -

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Rogério Brito
On Aug 21 2005, Andrew Morton wrote: > Rogério Brito <[EMAIL PROTECTED]> wrote: > > Unfortunately, it seems that current kernels (including vanilla -rc > > kernels) don't compile correctly on ppc if I have APM emulation > > enabled, but PMU disabled (only CUDA enabled). > > > > Here is what I get

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Benoit Boissinot
On Sun, Aug 21, 2005 at 06:34:48PM -0400, Jon Smirl wrote: > This should fix it, but I'm not on a machine where I can test it. Can > you give it a try and let me know? > it works ok. But there is still at least one problem: if ops->store returns an error, then there will be a substraction and the

Re: 2.6.13-rc6-mm1

2005-08-22 Thread John McCutchan
On Sat, 2005-08-20 at 23:52 -0700, Andrew Morton wrote: > Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > > > Hi, > > > > On 19/08/2005 11:37 a.m., Andrew Morton wrote: > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > > > > > - Lots of fixes, updat

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Jon Smirl
On 8/22/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > On Sun, Aug 21, 2005 at 06:34:48PM -0400, Jon Smirl wrote: > > This should fix it, but I'm not on a machine where I can test it. Can > > you give it a try and let me know? > > > > it works ok. > But there is still at least one problem: if o

Re: 2.6.13-rc6-mm1

2005-08-22 Thread Benoit Boissinot
On Mon, Aug 22, 2005 at 12:44:01PM -0400, Jon Smirl wrote: > On 8/22/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > > On Sun, Aug 21, 2005 at 06:34:48PM -0400, Jon Smirl wrote: > > > This should fix it, but I'm not on a machine where I can test it. Can > > > you give it a try and let me know? >

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Jon Smirl
> From: Benoit Boissinot <[EMAIL PROTECTED]> > To: Jon Smirl <[EMAIL PROTECTED]> > Subject: Re: 2.6.13-rc6-mm1 > User-Agent: Mutt/1.5.10i > > On Sun, Aug 21, 2005 at 06:11:57PM -0400, Jon Smirl wrote: > > On 8/21/05, Benoit Boissinot <[EMAIL PROTECTED]> wr

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Benoit Boissinot
- Forwarded message from Benoit Boissinot <[EMAIL PROTECTED]> - sorry, i forgot to reply all... From: Benoit Boissinot <[EMAIL PROTECTED]> To: Jon Smirl <[EMAIL PROTECTED]> Subject: Re: 2.6.13-rc6-mm1 User-Agent: Mutt/1.5.10i On Sun, Aug 21, 2005 at 06:11:57PM -040

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Jon Smirl
On 8/21/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > On Sun, Aug 21, 2005 at 01:40:31PM -0400, Jon Smirl wrote: > > On 8/21/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > > > On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/ak

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Benoit Boissinot
On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > - Lots of fixes, updates and cleanups all over the place. > > - If you have the right debugging options set, this kernel will generate > a storm

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Benoit Boissinot
On Sun, Aug 21, 2005 at 01:40:31PM -0400, Jon Smirl wrote: > On 8/21/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > > On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > > > > > - Lots of fi

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Jon Smirl
On 8/21/05, Benoit Boissinot <[EMAIL PROTECTED]> wrote: > On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > > > - Lots of fixes, updates and cleanups all over the place. > > > > - If you have the

Re: 2.6.13-rc6-mm1

2005-08-21 Thread Martin J. Bligh
> -scheduler-cache-hot-autodetect.patch > > Mabe Martin's machine crash That machine now boots again with this -mm release. Darren and/or I will continue trying to figure out what went wrong with this. M. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: 2.6.13-rc6-mm1

2005-08-20 Thread Andrew Morton
Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > Hi, > > On 19/08/2005 11:37 a.m., Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > > > - Lots of fixes, updates and cleanups all over the place. > > > > - If you have the right deb

Re: 2.6.13-rc6-mm1

2005-08-20 Thread Reuben Farrelly
Hi, On 19/08/2005 11:37 a.m., Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ - Lots of fixes, updates and cleanups all over the place. - If you have the right debugging options set, this kernel will generate a storm of sleeping-i

Re: 2.6.13-rc6-mm1

2005-08-20 Thread Reuben Farrelly
Hi, On 21/08/2005 1:40 a.m., David Woodhouse wrote: On Fri, 2005-08-19 at 18:36 -0700, Andrew Morton wrote: Reuben Farrelly <[EMAIL PROTECTED]> wrote: ... 4. PAM is complaining about "PAM audit_open() failed: Protocol not suppor ted" and I can't log in as any user including root. I would hav

Re: 2.6.13-rc6-mm1 [i6300escb.c 2 bugs, little cleanup]

2005-08-20 Thread Jiri Slaby
In i6300esb.c watchdog card driver were 2 bugs (misused pc_match_device and pci_dev_put wasn't called in one error case) and one little cleanup was done (long line was converted to a shorter one with using built-in macro). Generated in 2.6.13-rc6-mm1 kernel version. Signed-off-by: Jiri Slaby <[EM

Re: 2.6.13-rc6-mm1

2005-08-20 Thread Martin J. Bligh
--Andrew Morton <[EMAIL PROTECTED]> wrote (on Friday, August 19, 2005 04:33:31 -0700): > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > - Lots of fixes, updates and cleanups all over the place. > > - If you have the right debugging options set, t

Re: 2.6.13-rc6-mm1

2005-08-20 Thread David Woodhouse
On Fri, 2005-08-19 at 18:36 -0700, Andrew Morton wrote: > Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > > > ... > > >> 4. PAM is complaining about "PAM audit_open() failed: Protocol not suppor > > >> ted" and I can't log in as any user including root. I would have picked > > >> this > > >> was

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Andrew Morton
Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > ... > >> 4. PAM is complaining about "PAM audit_open() failed: Protocol not suppor > >> ted" and I can't log in as any user including root. I would have picked > >> this > >> was a userspace problem, but it doesn't break with -rc5-mm1, yet > >> rep

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Andrew Morton
Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > >> Aug 20 12:26:10 tornado kernel: Device not ready. > >> > >> 2. That message on the third line of the trace above: "kernel: Device > >> not > >> ready." is being logged every few mins or so, I believe it is my SCSI > >> CDROM > >> that is caus

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Reuben Farrelly
Hi again, On 20/08/2005 5:34 a.m., Andrew Morton wrote: Reuben Farrelly <[EMAIL PROTECTED]> wrote: A few new problems cropped up with this kernel.. 1. NFS seems to be unstable, oopsing when shutting down: --- devel/fs/nfsd/nfssvc.c~ingo-nfs-stuff-fix 2005-08-19 10:29:15.0 -0700

Re: 2.6.13-rc6-mm1: why is PHYLIB a user-visible option?

2005-08-19 Thread Jeff Garzik
Adrian Bunk wrote: Is there any reason why PHYLIB is a user-visible option? As far as I understand it, PHYLIB and the MII PHY device drivers are an internal library drivers should start to use roughly similar to MII. But in this case, the options shouldn't be user-visible. This code is stil

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Benoit Boissinot
On Fri, Aug 19, 2005 at 05:01:05PM -0400, Ed Tomlinson wrote: > Hi, > > Adding the include to dmi.h allows the compile to get past this point though I > wonder if this is the correct place to put it? (Thanks Benoit) > > I now get: > > CC [M] net/ipv4/ipvs/ip_vs_ctl.o > net/ipv4/ipvs/ip_vs_ct

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Avuton Olrich
On 8/19/05, Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Aug 19, 2005 at 09:42:51AM -0700, Avuton Olrich wrote: > > On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > - Lots of fixes, updates and cleanups all over the place. > > > > Problem: Badness during boot, seems to pertain to USB seri

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Greg KH
On Fri, Aug 19, 2005 at 09:42:51AM -0700, Avuton Olrich wrote: > On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > - Lots of fixes, updates and cleanups all over the place. > > Problem: Badness during boot, seems to pertain to USB serial driver/gameport > > Kernel Version: Linux version 2.

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Ed Tomlinson
Hi, Adding the include to dmi.h allows the compile to get past this point though I wonder if this is the correct place to put it? (Thanks Benoit) I now get: CC [M] net/ipv4/ipvs/ip_vs_ctl.o net/ipv4/ipvs/ip_vs_ctl.c:1601: error: static declaration of 'ipv4_table' follows non-static declarat

Re: 2.6.13-rc6-mm1: remove-asm-hdregh.patch problems

2005-08-19 Thread Andrew Morton
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > On Fri, Aug 19, 2005 at 04:33:31AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.13-rc5-mm1: > >... > > +remove-asm-hdregh.patch > > > > cleanup > >... > > This patch could be improved in two respects: > - it doesn't remove the xtensa hdreg.h

Re: 2.6.13-rc6-mm1 - OOPS in drivers/net/phy

2005-08-19 Thread Marc Ballarin
Hi, the changes to drivers/net/phy in git-netdev-all.patch have some issues: 1) phy.c (libphy.ko) lacks MODULE_LICENCE(GPL), but uses GPL-only exports 2) after fixing this (or when compiling statically) it causes the following OOPS (new in rc6-mm1): Badness in kref_get at lib/kref.c:32 [] dump_

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Andrew Morton
Dave Kleikamp <[EMAIL PROTECTED]> wrote: > > It seems that git-ocfs2.patch duplicates the > update-filesystems-for-new-delete_inode-behavior.patch. I noticed it > adds duplicate statements like: > > diff -puN fs/ext2/inode.c~git-ocfs2 fs/ext2/inode.c > diff -puN fs/ext3/inode.c~git-ocfs2 fs/ext3/

Re: 2.6.13-rc6-mm1

2005-08-19 Thread hallyn
I get a compile error due to the removal of scsi_cmd->timeout. I have no idea whether the following is correct (I doubt it is), but it does fix a compile error, and the resulting kernel at least survives repeated dbench'es. thanks, -serge Signed-off-by: Serge Hallyn <[EMAIL PROTECTED] -- ibmvsc

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Jesper Juhl
On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > menuconfig complains a little : $ make menuconfig scripts/kconfig/mconf arch/i386/Kconfig drivers/char/Kconfig:847:warning: 'select' used by config

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Andrew Morton
Reuben Farrelly <[EMAIL PROTECTED]> wrote: > > Hi, > > On 19/08/2005 11:33 p.m., Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ > > > > - Lots of fixes, updates and cleanups all over the place. > > > > - If you have the right deb

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Avuton Olrich
On 8/19/05, Andrew Morton <[EMAIL PROTECTED]> wrote: > - Lots of fixes, updates and cleanups all over the place. Problem: Badness during boot, seems to pertain to USB serial driver/gameport Kernel Version: Linux version 2.6.13-rc6-mm1 ([EMAIL PROTECTED]) (gcc version 3.4.4 (Gentoo 3.4.4, ssp-3.4.

Re: 2.6.13-rc6-mm1: drivers/scsi/aic7xxx/ compile error

2005-08-19 Thread Christoph Hellwig
On Fri, Aug 19, 2005 at 06:40:36PM +0200, Adrian Bunk wrote: > <-- snip --> > > ... > LD drivers/scsi/aic7xxx/built-in.o > drivers/scsi/aic7xxx/aic79xx.o: In function `aic_parse_brace_option': > : multiple definition of `aic_parse_brace_option' > drivers/scsi/aic7xxx/aic7xxx.o:: first def

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Dave Kleikamp
It seems that git-ocfs2.patch duplicates the update-filesystems-for-new-delete_inode-behavior.patch. I noticed it adds duplicate statements like: diff -puN fs/ext2/inode.c~git-ocfs2 fs/ext2/inode.c diff -puN fs/ext3/inode.c~git-ocfs2 fs/ext3/inode.c --- devel/fs/ext3/inode.c~git-ocfs2 2005-08

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Benoit Boissinot
On 8/19/05, Ed Tomlinson <[EMAIL PROTECTED]> wrote: > On Friday 19 August 2005 07:33, Andrew Morton wrote: > > - Lots of fixes, updates and cleanups all over the place. > > > > - If you have the right debugging options set, this kernel will generate > > a storm of sleeping-in-atomic-code warnings a

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Ed Tomlinson
On Friday 19 August 2005 07:33, Andrew Morton wrote: > - Lots of fixes, updates and cleanups all over the place. > > - If you have the right debugging options set, this kernel will generate >   a storm of sleeping-in-atomic-code warnings at boot, from the scsi code. >   It is being worked on. > >

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:45, Russell King a écrit : > #ifdef CONFIG_SMP > extern int smp_nmi_call_function(void (*fn)(void *), void *priv, int whatever); > #else > static inline int smp_nmi_call_function(void (*fn)(void *), void *priv, int whatever) > { > return 0; > } > #endif > > Obviously I've pro

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Russell King
On Fri, Aug 19, 2005 at 03:41:29PM +0200, Brice Goglin wrote: > Le 19.08.2005 15:27, Russell King a écrit : > > Since you're going to be adding #ifdef CONFIG_SMP...#endif around each > > of these, why not fix where it's declared/defined to be empty? > > Probably because I'm too lazy to find a nice

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:27, Russell King a écrit : > Since you're going to be adding #ifdef CONFIG_SMP...#endif around each > of these, why not fix where it's declared/defined to be empty? Probably because I'm too lazy to find a nice way to fix it :) smp_nmi_call_function may return an error but I don't

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Russell King
On Fri, Aug 19, 2005 at 03:25:19PM +0200, Brice Goglin wrote: > arch/i386/kernel/traps.c: In function 'die_nmi': > arch/i386/kernel/traps.c:633: warning: statement with no effect > > Another smp_nmi_call. > > Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Since you're going to be adding #ifdef

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
arch/i386/kernel/traps.c: In function 'die_nmi': arch/i386/kernel/traps.c:633: warning: statement with no effect Another smp_nmi_call. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Brice --- linux-mm/arch/i386/kernel/traps.c.old 2005-08-19 15:19:14.0 +0200 +++ linux-mm/arch/i38

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Le 19.08.2005 15:18, Brice Goglin a écrit : > drivers/char/sysrq.c: In function 'sysrq_handle_showregs': > drivers/char/sysrq.c:186: warning: statement with no effect > > This is caused by a smp call while CONFIG_SMP is not set. > The attached patch fixes this. Oops, reverted by mistake. Good one

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Reuben Farrelly
Hi, On 19/08/2005 11:33 p.m., Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.13-rc6/2.6.13-rc6-mm1/ - Lots of fixes, updates and cleanups all over the place. - If you have the right debugging options set, this kernel will generate a storm of sleeping-i

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
drivers/char/sysrq.c: In function 'sysrq_handle_showregs': drivers/char/sysrq.c:186: warning: statement with no effect This is caused by a smp call while CONFIG_SMP is not set. The attached patch fixes this. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Brice --- linux-mm/drivers/char/sysrq.

Re: 2.6.13-rc6-mm1

2005-08-19 Thread Brice Goglin
Hi Andrew, Got this warning: drivers/char/drm/drm_agpsupport.c:429:5: warning: "LINUX_VERSION_CODE" is not defined This test is for old 2.4 code. The attached patch simply removes it. Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Regards, Brice --- linux-mm/drivers/char/drm/drm_agpsupport.c.