Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-08 Thread Vaishali Thakkar
On Saturday 03 September 2016 08:53 PM, Jonathan Cameron wrote: > On 02/09/16 09:05, Pavel Andrianov wrote: >> > >> Hi! > Hi Pavel, >> >> There is a potential race in drivers/iio/adc/vf610_adc.ko. Handlers >> vf610_set_conversion_mode and vf610_write_raw are called via >> device_attibute interfa

Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-05 Thread Jonathan Cameron
On 05/09/16 07:49, Vaishali Thakkar wrote: > > > On Saturday 03 September 2016 08:53 PM, Jonathan Cameron wrote: >> On 02/09/16 09:05, Pavel Andrianov wrote: >>> >> >>> Hi! >> Hi Pavel, >>> >>> There is a potential race in drivers/iio/adc/vf610_adc.ko. Handlers >>> vf610_set_conversion_mode and v

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Pavel Andrianov, on Mon 05 Sep 2016 13:33:33 +0300, wrote: > synth_direct_store may be called via device_attributes interface. Ah, right. > In which function the lock should be added? That'd be synth_direct_store then, around the while loop. Samuel

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Pavel Andrianov
05.09.2016 12:56, Samuel Thibault пишет: Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote: 05.09.2016 12:43, Samuel Thibault пишет: Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: There is a potential race in drivers/staging/speakup/speakup.ko. All operations with global po

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Pavel Andrianov, on Mon 05 Sep 2016 12:54:10 +0300, wrote: > 05.09.2016 12:43, Samuel Thibault пишет: > >Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: > >>There is a potential race in drivers/staging/speakup/speakup.ko. > >>All operations with global pointers buff_in and buff_out are p

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Pavel Andrianov
05.09.2016 12:43, Samuel Thibault пишет: Hello, Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: There is a potential race in drivers/staging/speakup/speakup.ko. All operations with global pointers buff_in and buff_out are performed without any locks. Thus, a simultaneous write (via s

Re: A potential race in drivers/staging/speakup/speakup.ko

2016-09-05 Thread Samuel Thibault
Hello, Pavel Andrianov, on Mon 05 Sep 2016 11:51:50 +0300, wrote: > There is a potential race in drivers/staging/speakup/speakup.ko. > All operations with global pointers buff_in and buff_out are performed > without any locks. Thus, a simultaneous write (via synth_buffer_clear or > synth_buffer_ad

Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-05 Thread Vaishali Thakkar
On Saturday 03 September 2016 08:53 PM, Jonathan Cameron wrote: > On 02/09/16 09:05, Pavel Andrianov wrote: >> > >> Hi! > Hi Pavel, >> >> There is a potential race in drivers/iio/adc/vf610_adc.ko. Handlers >> vf610_set_conversion_mode and vf610_write_raw are called via >> device_attibute interfa

Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-03 Thread Jonathan Cameron
On 02/09/16 09:05, Pavel Andrianov wrote: > > Hi! Hi Pavel, > > There is a potential race in drivers/iio/adc/vf610_adc.ko. Handlers > vf610_set_conversion_mode and vf610_write_raw are called via > device_attibute interface, but they are related to different > attributes, so may be executed in pa

Re: A potential race in drivers/iio/adc/vf610_adc.ko

2016-09-02 Thread Alison Schofield
On Fri, Sep 02, 2016 at 11:05:09AM +0300, Pavel Andrianov wrote: > > Hi! > > There is a potential race in drivers/iio/adc/vf610_adc.ko. > Handlers vf610_set_conversion_mode and vf610_write_raw are called via > device_attibute interface, but they are related to different attributes, so > may be ex

Re: A potential race

2016-07-08 Thread Pavel Andrianov
Hi! We have no hardware to test possible fixes. If somebody has it and agrees to check our patches, we will prepare them. Best regards, Pavel 01.07.2016 20:17, Hans Verkuil пишет: On 07/01/2016 05:02 PM, Pavel Andrianov wrote: 01.07.2016 19:53, Hans Verkuil пишет: On 07/01/2016 04:39 PM, P

Re: A potential race

2016-07-01 Thread Hans Verkuil
On 07/01/2016 05:02 PM, Pavel Andrianov wrote: > 01.07.2016 19:53, Hans Verkuil пишет: >> On 07/01/2016 04:39 PM, Pavel Andrianov wrote: >>> Hi! >>> >>> There is a potential race condition between usbvision_v4l2_close and >>> usbvision_disconnect. The possible scenario may be the following. >>>

Re: A potential race

2016-07-01 Thread Pavel Andrianov
01.07.2016 19:53, Hans Verkuil пишет: On 07/01/2016 04:39 PM, Pavel Andrianov wrote: Hi! There is a potential race condition between usbvision_v4l2_close and usbvision_disconnect. The possible scenario may be the following. usbvision_disconnect starts execution, assigns usbvision->remove_pe

Re: A potential race

2016-07-01 Thread Hans Verkuil
On 07/01/2016 04:39 PM, Pavel Andrianov wrote: > Hi! > > There is a potential race condition between usbvision_v4l2_close > > and usbvision_disconnect >