Re: Bug in ks8851.c

2014-04-01 Thread David Miller
From: "Nekludov, Max" Date: Tue, 1 Apr 2014 15:41:58 + > Reset on RX failure and TX timeout. > > Electromagnetic noice can make device to not send TX interrupts. > As result outgoing queue will be suspended forever. > Also EMI can raise RX interrupt with zero value in KS_RXFC register. > >

Re: Bug in ks8851.c

2013-03-29 Thread David Miller
From: max.neklu...@us.elster.com Date: Fri, 29 Mar 2013 19:27:36 +0400 > Denis, > here is patch with commit message: > > Subject: [PATCH] Fix bug in ks8851 driver > > According to the Datasheet (page 52): > 15-12 Reserved > 11-0 RXBC Receive Byte Count > This field indicates the present received

Re: Bug in ks8851.c

2013-03-28 Thread Max . Nekludov
Linus, I tried to send the mail to 'Ben Dooks ' but the address is dead now. > I assume you've tested it in practice? Yes, I'm running the modified code both in bootloader and Linux kernel on my board. Thanks, Max Signed-off-by: Max Nekludov --- drivers/net/ethernet/micrel/ks8851.c | 2 +- 1

Re: Bug in ks8851.c

2013-03-28 Thread Linus Torvalds
Max, please cc the actual maintainers of the driver. The patch looks sane, though. I assume you've tested it in practice? You also seem to have based this on an ancient version, the code has long since moved from drivers/net/ks8851.c to drivers/net/ethernet/micrel/ks8851.c (back in June of 2011),