Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-16 Thread Robin Murphy
On 16/10/17 09:12, Vladimir Murzin wrote: > + Robin and Christoph > > On 16/10/17 06:27, Marian Mihailescu wrote: >> I am using 4.14-rc4 with a patch on top that includes >> arch/arm/include/asm/dma-mapping.h in a module. >> >> I have MMU enabled, so >> select DMA_NOOP_OPS if !MMU >> does nothing

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-16 Thread Vladimir Murzin
+ Robin and Christoph On 16/10/17 06:27, Marian Mihailescu wrote: > I am using 4.14-rc4 with a patch on top that includes > arch/arm/include/asm/dma-mapping.h in a module. > > I have MMU enabled, so > select DMA_NOOP_OPS if !MMU > does nothing for me, and I get a compile error because dma_noop_op

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Marian Mihailescu
I am using 4.14-rc4 with a patch on top that includes arch/arm/include/asm/dma-mapping.h in a module. I have MMU enabled, so select DMA_NOOP_OPS if !MMU does nothing for me, and I get a compile error because dma_noop_ops is unknown. Maybe I should include linux/dma-mapping.h? Thanks for the quic

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 20:29, Randy Dunlap wrote: > On 10/15/17 20:27, Randy Dunlap wrote: >> On 10/15/17 19:27, Marian Mihailescu wrote: >>> After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops >>> are built only for architectures that use it. >>> >>> For ARM architecture, CONFIG_DMA_NOOP_OPS

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 20:27, Randy Dunlap wrote: > On 10/15/17 19:27, Marian Mihailescu wrote: >> After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops >> are built only for architectures that use it. >> >> For ARM architecture, CONFIG_DMA_NOOP_OPS is not selected, and cannot >> be selected. >>

Re: CONFIG_DMA_NOOP_OPS breaks ARM arch

2017-10-15 Thread Randy Dunlap
On 10/15/17 19:27, Marian Mihailescu wrote: > After commit 7844572c633964c864d9f32dc3f2a8ffe5d70371, dma_noop_ops > are built only for architectures that use it. > > For ARM architecture, CONFIG_DMA_NOOP_OPS is not selected, and cannot > be selected. > > However, arch/arm/include/asm/dma-mapping.