Re: Display class

2007-01-14 Thread Greg KH
On Sat, Jan 13, 2007 at 10:40:55PM +, James Simmons wrote: > > > Hi, > > > > On Tuesday 05 December 2006 13:03, James Simmons wrote: > > > +int probe_edid(struct display_device *dev, void *data) > > > +{ > > > +???struct fb_monspecs spec; > > > +???ssize_t size = 45; > > That code wa

Re: Display class

2007-01-14 Thread Greg KH
On Sat, Jan 13, 2007 at 10:40:55PM +, James Simmons wrote: > > > Hi, > > > > On Tuesday 05 December 2006 13:03, James Simmons wrote: > > > +int probe_edid(struct display_device *dev, void *data) > > > +{ > > > +???struct fb_monspecs spec; > > > +???ssize_t size = 45; > > That code wa

Re: Display class

2007-01-13 Thread James Simmons
> Hi, > > On Tuesday 05 December 2006 13:03, James Simmons wrote: > > +int probe_edid(struct display_device *dev, void *data) > > +{ > > +   struct fb_monspecs spec; > > +   ssize_t size = 45; That code was only for testing. I do have new core code. Andrew could you merge this patch as

Re: Display class

2006-12-29 Thread Dmitry Torokhov
Hi, On Tuesday 05 December 2006 13:03, James Simmons wrote: > +int probe_edid(struct display_device *dev, void *data) > +{ > +   struct fb_monspecs spec; > +   ssize_t size = 45; const ssize_t size = 45? > + > +   dev->name = kzalloc(size, GFP_KERNEL); Why do you need kzalloc here?

Re: Display class

2006-12-08 Thread Miguel Ojeda
On 12/7/06, James Simmons <[EMAIL PROTECTED]> wrote: > P.S. > > When I was working at 2.6.19-rc6-mm2 it worked all fine, but now > I have copied it to git7 I'm getting some weird segmentation faults > (oops) when at cfag12864bfb_init, at mutex_lock() in > display_device_unregister module

Re: Display class

2006-12-07 Thread Miguel Ojeda
On 12/7/06, James Simmons <[EMAIL PROTECTED]> wrote: > - I would remove "struct device *dev, void *devdata" of display_device_register() > Are they neccesary for other display drivers? I have to pass NULL right now. Yes. Passing in a struct device allows you a link between the device an

Re: Display class

2006-12-07 Thread James Simmons
> - I would remove "struct device *dev, void *devdata" of > display_device_register() > Are they neccesary for other display drivers? I have to pass NULL right > now. Yes. Passing in a struct device allows you a link between the device and the class. If you pass in the device for the par

Re: Display class

2006-12-06 Thread Randy Dunlap
On Wed, 6 Dec 2006 15:10:44 + (GMT) James Simmons wrote: > > > > of Mr. Yu for acpi. Also this class could in time replace the lcd class > > > located in the backlight directory since a lcd is a type of display. > > > The final hope is that the purpose auxdisplay could fall under this > > >

Re: Display class

2006-12-06 Thread James Simmons
> > > > That patch was rought draft for feedback. I applied your comments. This > > > > patch actually works. It includes my backlight fix as well. > > > > > > Glad to hear it. I had to make the following changes > > > in order for it to build. > > > However, I still have build errors for aty.

Re: Display class

2006-12-06 Thread Miguel Ojeda
On 12/6/06, Miguel Ojeda Sandonis <[EMAIL PROTECTED]> wrote: Ok, here is the patch (against git7+displayclass) which moves auxdisplay/* to video/display/* and start using the display class. It is just a draft, but there isn't much code changed from -mm2. - I would remove "struct device *dev,

Re: Display class

2006-12-06 Thread Randy Dunlap
On Wed, 6 Dec 2006 18:24:08 + (GMT) James Simmons wrote: > > > > That patch was rought draft for feedback. I applied your comments. This > > > patch actually works. It includes my backlight fix as well. > > > > Glad to hear it. I had to make the following changes > > in order for it to bui

Re: Display class

2006-12-06 Thread Miguel Ojeda Sandonis
Ok, here is the patch (against git7+displayclass) which moves auxdisplay/* to video/display/* and start using the display class. It is just a draft, but there isn't much code changed from -mm2. - I would remove "struct device *dev, void *devdata" of display_device_register() Are they necce

Re: Display class

2006-12-06 Thread James Simmons
> > That patch was rought draft for feedback. I applied your comments. This > > patch actually works. It includes my backlight fix as well. > > Glad to hear it. I had to make the following changes > in order for it to build. > However, I still have build errors for aty. Ug. I see another probl

Re: Display class

2006-12-06 Thread Randy Dunlap
On Wed, 6 Dec 2006 15:10:44 + (GMT) James Simmons wrote: > > > > of Mr. Yu for acpi. Also this class could in time replace the lcd class > > > located in the backlight directory since a lcd is a type of display. > > > The final hope is that the purpose auxdisplay could fall under this > > >

Re: Display class

2006-12-06 Thread James Simmons
> > of Mr. Yu for acpi. Also this class could in time replace the lcd class > > located in the backlight directory since a lcd is a type of display. > > The final hope is that the purpose auxdisplay could fall under this > > catergory. > > > > P.S > >I know the edid parsing would have to be

Re: Display class

2006-12-06 Thread Miguel Ojeda
On 12/5/06, James Simmons <[EMAIL PROTECTED]> wrote: This is the pass at a display class to meet the needs of the output class of Mr. Yu for acpi. Also this class could in time replace the lcd class located in the backlight directory since a lcd is a type of display. The final hope is that the p

Re: Display class

2006-12-05 Thread Randy Dunlap
On Tue, 5 Dec 2006 18:03:39 + (GMT) James Simmons wrote: > This is the pass at a display class to meet the needs of the output class > of Mr. Yu for acpi. Also this class could in time replace the lcd class > located in the backlight directory since a lcd is a type of display. > The final ho