Re: Ext2 Directory Index - File Structure

2001-04-16 Thread Daniel Phillips
On Monday 16 April 2001 14:40, you wrote: > Daniel, you write (re indexed directories): > > Superblock Feature Flag > > --- > > > > This is now incorporated. I use the following code: > > > > if (!EXT2_HAS_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_DIR_INDEX)) > > { > >

Re: Ext2 Directory Index - File Structure

2001-04-16 Thread Daniel Phillips
Andreas, you wrote: > Daniel, you write: > > Andreas, you wrote: > > > We should go with "EXT2_FEATURE_COMPAT_DIR_INDEX 0x0008" > > > because the on-disk layout is 100% compatible with older kernels, so > > > no reason to force read-only for those systems. I'm guessing Ted had > > > put RO_COMPAT

Re: Ext2 Directory Index - File Structure

2001-04-15 Thread Andreas Dilger
Daniel, you write (re indexed directories): > Superblock Feature Flag > --- > > This is now incorporated. I use the following code: > > if (!EXT2_HAS_COMPAT_FEATURE(sb, EXT2_FEATURE_COMPAT_DIR_INDEX)) > { > lock_kernel(); > ext2_update

Re: Ext2 Directory Index - File Structure

2001-04-15 Thread Andreas Dilger
Daniel, you write: > Andreas, you wrote: > > We should go with "EXT2_FEATURE_COMPAT_DIR_INDEX 0x0008" > > because the on-disk layout is 100% compatible with older kernels, so > > no reason to force read-only for those systems. I'm guessing Ted had > > put RO_COMPAT_BTREE_DIR in there in anticipat

Re: Ext2 Directory Index - File Structure

2001-04-15 Thread Daniel Phillips
Andreas, you wrote: > Daniel, you write: > > So then, the obvious candidate would be: > > > > #define EXT2_FEATURE_RO_COMPAT_DIR_INDEX0x0004 > > > > which was formerly EXT2_FEATURE_RO_COMPAT_BTREE_DIR. > > Actually not. We should go with "EXT2_FEATURE_COMPAT_DIR_INDEX 0x0008" > becaus

Re: Ext2 Directory Index - File Structure

2001-04-13 Thread Andreas Dilger
Daniel, you write: > OK, I get it. Nice article - it would sure be nice to see this > incorporated Documentation/filesystems/ext2.txt. I just checked my copy > of Understanding the Linux Kernel and while existence of the compat > fields in the super block is noted, there is nothing at all said a

Re: Ext2 Directory Index - File Structure

2001-04-13 Thread Daniel Phillips
Andreas Dilger wrote: > Daniel writes: > > > Are you going to go to a COMPAT flag before final release? This is > > > pretty much needed for e2fsck to be able to detect/correct indexes. > > > > I will if I know what the exact semantics are. I have only an > > approximate idea of how this works a

Re: Ext2 Directory Index - File Structure

2001-04-10 Thread Andreas Dilger
Daniel writes: > > Are you going to go to a COMPAT flag before final release? This is > > pretty much needed for e2fsck to be able to detect/correct indexes. > > I will if I know what the exact semantics are. I have only an > approximate idea of how this works and I'd appreciate a more precise