Re: Input: add Atmel Atmegaxx captouch driver

2016-05-09 Thread Grant Grundler
On Mon, May 9, 2016 at 9:29 AM, Dmitry Torokhov wrote: > On Fri, May 06, 2016 at 11:14:12PM +0800, Daniel Hung-yu Wu wrote: >> The register set is different, and this chip does not support calibration. >> The I2C protocol is not the same as well; there is an additional byte >> indicating data leng

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-09 Thread Dmitry Torokhov
On Fri, May 06, 2016 at 11:14:12PM +0800, Daniel Hung-yu Wu wrote: > The register set is different, and this chip does not support calibration. > The I2C protocol is not the same as well; there is an additional byte > indicating data length. > > Atmega88PA is a general-purpose MCU. In the future,

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-06 Thread Grant Grundler
On Fri, May 6, 2016 at 2:19 AM, Nicolas Ferre wrote: ... > Is it different from the Atmel QT1070 or QT2160 which have drivers > already available in Linux: drivers/input/keyboard/qt1070.c Yes. What Daniel said. I would describe it as "probe code and interrupt handling protocol are different" f

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-06 Thread Nicolas Ferre
Le 05/05/2016 18:04, Grant Grundler a écrit : > On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote: > ... >>> +Required properties: >>> + >>> + compatible: Must be "atmel,atmegaxx_captouch". >> >> No wildcards in the compatible strings. Use the specific devices. >> >> Also, use hyphen rathe

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-05 Thread Grant Grundler
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote: ... >> +Required properties: >> + >> + compatible: Must be "atmel,atmegaxx_captouch". > > No wildcards in the compatible strings. Use the specific devices. > > Also, use hyphen rather than underscore. However, if the device is only > a tou

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-04 Thread Grant Grundler
On Wed, May 4, 2016 at 6:51 AM, Rob Herring wrote: > On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote: >> Add I2C driver for AtmegaXX capacitive touch device. >> >> Signed-off-by: Hung-yu Wu >> Signed-off-by: Grant Grundler >> --- >> .../bindings/input/atmel,atmegaxx_captouch.txt

Re: Input: add Atmel Atmegaxx captouch driver

2016-05-04 Thread Rob Herring
On Tue, May 03, 2016 at 10:13:31AM -0700, Grant Grundler wrote: > Add I2C driver for AtmegaXX capacitive touch device. > > Signed-off-by: Hung-yu Wu > Signed-off-by: Grant Grundler > --- > .../bindings/input/atmel,atmegaxx_captouch.txt | 34 +++ It is generally preferred that bindings are