Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-05 Thread Eric W. Biederman
Al Viro writes: > Speaking of bogosities, apparently nobody has noticed that automagical > turning BSD process accounting off upon r/o remounts of the filesystem > hosting the log got broken several years ago. Suppose we find an opened > log when remounting. OK, it gets closed, which means filp

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-05 Thread Linus Torvalds
On Mon, Aug 4, 2014 at 9:56 PM, Steven Noonan wrote: > > Er, grep failed me. The above delta to gfs2 is obviously bogus. Yeah, and looking at the patch, I think the "make lockref count signed" should be a separate patch. Linus -- To unsubscribe from this list: send the line "unsubscr

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Al Viro
On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: > So renaming it to "lockref_get_active()", and changing the "not zero" > test to check for "positive" and change the rtype of "count" to be > signed, all sound like good things to me. Fine by me. I can do that, unless somebody else

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 4, 2014 at 9:54 PM, Steven Noonan wrote: > On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: >> On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown wrote: >> > >> > I've been looking at last year's change to dentry refcounting which sets >> > the >> > refcount to -128 (mark_dea

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Steven Noonan
On Mon, Aug 04, 2014 at 09:07:32PM -0700, Linus Torvalds wrote: > On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown wrote: > > > > I've been looking at last year's change to dentry refcounting which sets > > the > > refcount to -128 (mark_dead()) when the dentry is gone. > > > > As this is an "unsigne

Re: Is lockref_get_not_zero() really correct in dget_parent()

2014-08-04 Thread Linus Torvalds
On Mon, Aug 4, 2014 at 8:17 PM, NeilBrown wrote: > > I've been looking at last year's change to dentry refcounting which sets the > refcount to -128 (mark_dead()) when the dentry is gone. > > As this is an "unsigned long" and there are several places where > d_lockref.count is compared e.g. ">