Re: Linux 2.6.22-rc7

2007-07-03 Thread Ingo Molnar
* Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Tue, 3 Jul 2007, Ingo Molnar wrote: > > > yeah. Your change looks good to me. You could add a > > local_irq_enable_in_hardirq() to the original place, that will map > > to a local_irq_enable() on non-lockdep kernels and will be a NOP on > >

Re: Linux 2.6.22-rc7

2007-07-03 Thread Christoph Lameter
On Tue, 3 Jul 2007, Ingo Molnar wrote: > yeah. Your change looks good to me. You could add a > local_irq_enable_in_hardirq() to the original place, that will map to a > local_irq_enable() on non-lockdep kernels and will be a NOP on lockdep > kernels. (This is a bit hacky though.) Then kernels

Re: Linux 2.6.22-rc7

2007-07-03 Thread Ingo Molnar
* Christoph Lameter <[EMAIL PROTECTED]> wrote: > > However, it might be worth avoiding the warning, even if it seems > > bogus in this case. Christoph? Do you agree with the analysis? And > > the patch might be as simple as changing > > early_kmem_cache_node_alloc() to enable interrupts at the

Re: Linux 2.6.22-rc7

2007-07-03 Thread Andre Noll
On 09:31, Christoph Lameter wrote: > > Andre, does that simple change fix it for you (move the > > "local_irq_enable()" to the end of early_kmem_cache_node_alloc)? > > Yes that should make the lock checker happy since interrupts are disabled > when calling add_partial(). local_irq_enable can be

Re: Linux 2.6.22-rc7

2007-07-03 Thread Christoph Lameter
On Tue, 3 Jul 2007, Linus Torvalds wrote: > > There seems to be a locking problem: > > Ok, I _think_ this is actually ok, and the lock validator is unhappy just > because we don't disable irq's when initializing the slab, so the fact > that we take the list_lock with interrupts enabled looks sc

RE: Linux 2.6.22-rc7

2007-07-03 Thread Martin Knoblauch
>Ok, Linux-2.6.22-rc7 is out there. > >It's hopefully (almost certainly) the last -rc before the final 2.6.22 >release, and we should be in pretty good shape. The flow of patches has >really slowed down and the regression list has shrunk a lot. > >The shortlog/diffstat reflects that, with the bigge

Re: Linux 2.6.22-rc7

2007-07-03 Thread Linus Torvalds
On Tue, 3 Jul 2007, Andre Noll wrote: > > On 14:32, Linus Torvalds wrote: > > > > Ok, Linux-2.6.22-rc7 is out there. > > > > Final testing always appreciated, of course, > > There seems to be a locking problem: Ok, I _think_ this is actually ok, and the lock validator is unhappy just because