Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-03-04 Thread Oleg Nesterov
On 03/04, Lianwei Wang wrote: > > Freeze/Thaw is a hot path for the Linux based mobile OS, e.g. Android. > If we don't remove the pending fake signal, then the user space apps > or the related kernel driver has to handle such error. But if we add recalc_sigpending() we penalize the common case whi

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-03-04 Thread Tejun Heo
Hello, On Mon, Mar 04, 2013 at 11:24:06AM +0800, Lianwei Wang wrote: > Freeze/Thaw is a hot path for the Linux based mobile OS, e.g. Android. > If we don't remove the pending fake signal, then the user space apps Hotness is relative. How often are we talking about? Do you have any numbers backi

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-03-03 Thread Lianwei Wang
Sorry for the late response. Freeze/Thaw is a hot path for the Linux based mobile OS, e.g. Android. If we don't remove the pending fake signal, then the user space apps or the related kernel driver has to handle such error. And yes, the user can handle such case by checking the return value, but i

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-02-26 Thread Oleg Nesterov
Damn. Tejun, et all, sorry for confusion. Somehow I misunderstood your email completely! as if you argue with my "freezer: do not send a fake signal to a PF_DUMPCORE thread" change http://marc.info/?l=linux-kernel&m=136173112604220 As for "add fake signal clearing back when thaw task", I do not

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-02-26 Thread Oleg Nesterov
Ah, I just noticed that the changelog mentions wait_event_freezable() too, On 02/25, Tejun Heo wrote: > > > Subject: [PATCH] freezer: add fake signal clearing back when thaw task > > > > The fake TIF_SIGPENDING is set during freeze userspace process, but it > > is not cleared when thaw tasks after

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-02-26 Thread Oleg Nesterov
On 02/25, Tejun Heo wrote: > > (cc'ing Rafael and Oleg and quoting whole body) > > On Thu, Feb 21, 2013 at 02:19:21PM +0800, Lianwei Wang wrote: > > Hi Tejun Heo and all, > > > > The commit of "34b087e freezer: kill unused > > set_freezable_with_signal()" remove recalc_sigpending*() calls in > > fr

Re: PATCH: freezer: add fake signal clearing back when thaw task

2013-02-25 Thread Tejun Heo
(cc'ing Rafael and Oleg and quoting whole body) On Thu, Feb 21, 2013 at 02:19:21PM +0800, Lianwei Wang wrote: > Hi Tejun Heo and all, > > The commit of "34b087e freezer: kill unused > set_freezable_with_signal()" remove recalc_sigpending*() calls in > freezer, so the user tasks get TIF_SIGPENDING