Re: PREEMPT is messing with everyone

2006-12-05 Thread Jan Engelhardt
> Yes, Compiler will remove it but this looks ugly and confusing. > > Why dont we use like this :- Even more fugly. > # ifdef CONFIG_PREEMPT > # include > # endif > > #ifdef CONFIG_PREEMPT > preempt_disable(); > #endif > > #ifdef CONFIG_PREEMPT > preempt_enable(); > #endif > -`J' -- -

Re: PREEMPT is messing with everyone

2006-12-05 Thread Bill Davidsen
Jaswinder Singh wrote: On 12/5/06, Michal Schmidt <[EMAIL PROTECTED]> wrote: Jaswinder Singh wrote: > Hi, > > preempt stuff SHOULD only stay in #ifdef CONFIG_PREEMP_* , but it is > messing with everyone even though not defined. > > e.g. > > 1. linux-2.6.19/kernel/spinlock.c > > Line 18: #include

Re: PREEMPT is messing with everyone

2006-12-05 Thread Michal Schmidt
Jaswinder Singh skrev: Yes, Compiler will remove it but this looks ugly and confusing. Why dont we use like this :- #ifdef CONFIG_PREEMPT #include #endif #ifdef CONFIG_PREEMPT preempt_disable(); #endif #ifdef CONFIG_PREEMPT preempt_enable(); #endif Surely you're joking. It is much more r

Re: PREEMPT is messing with everyone

2006-12-05 Thread Jaswinder Singh
On 12/5/06, Michal Schmidt <[EMAIL PROTECTED]> wrote: Jaswinder Singh wrote: > Hi, > > preempt stuff SHOULD only stay in #ifdef CONFIG_PREEMP_* , but it is > messing with everyone even though not defined. > > e.g. > > 1. linux-2.6.19/kernel/spinlock.c > > Line 18: #include > > Line 26: preempt_

Re: PREEMPT is messing with everyone

2006-12-05 Thread Michal Schmidt
Jaswinder Singh wrote: Hi, preempt stuff SHOULD only stay in #ifdef CONFIG_PREEMP_* , but it is messing with everyone even though not defined. e.g. 1. linux-2.6.19/kernel/spinlock.c Line 18: #include Line 26: preempt_disable(); Line 32: preempt_disable(); and so on . Don't worry. Thes