Re: Potential data race in psmouse_interrupt

2015-09-07 Thread Dmitry Vyukov
I've mailed a separate patch that does serio_pause_rx before reading out data ("input: fix data race __ps2_command"). On Sat, Sep 5, 2015 at 3:21 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov > wrote: >> On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: >>> On

Re: Potential data race in psmouse_interrupt

2015-09-05 Thread Dmitry Vyukov
On Fri, Sep 4, 2015 at 10:27 PM, Dmitry Torokhov wrote: > On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: >> On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov >> wrote: >>> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov wrot

Re: Potential data race in psmouse_interrupt

2015-09-04 Thread Dmitry Torokhov
On Fri, Sep 4, 2015 at 12:32 PM, Dmitry Vyukov wrote: > On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov > wrote: >> On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >>> wrote: On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote:

Re: Potential data race in psmouse_interrupt

2015-09-04 Thread Dmitry Vyukov
On Fri, Sep 4, 2015 at 6:56 PM, Dmitry Torokhov wrote: > On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov wro

Re: Potential data race in psmouse_interrupt

2015-09-04 Thread Dmitry Torokhov
On Tue, Sep 1, 2015 at 11:46 AM, Dmitry Vyukov wrote: > On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >>> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >>> wrote: On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote

Re: Potential data race in psmouse_interrupt

2015-09-01 Thread Dmitry Vyukov
On Fri, Aug 28, 2015 at 8:32 PM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: Hello, I am looking at this code in __ps2_comm

Re: Potential data race in psmouse_interrupt

2015-08-28 Thread Dmitry Torokhov
On Fri, Aug 28, 2015 at 11:32 AM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: >> On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov >> wrote: >>> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: Hello, I am looking at this code in __ps2_com

Re: Potential data race in psmouse_interrupt

2015-08-28 Thread Dmitry Torokhov
On Fri, Aug 28, 2015 at 11:08 AM, Dmitry Vyukov wrote: > On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov > wrote: >> On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: >>> Hello, >>> >>> I am looking at this code in __ps2_command again: >>> >>> /* >>> * The reset command takes a long time t

Re: Potential data race in psmouse_interrupt

2015-08-28 Thread Dmitry Vyukov
On Fri, Aug 28, 2015 at 7:51 PM, Dmitry Torokhov wrote: > On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: >> Hello, >> >> I am looking at this code in __ps2_command again: >> >> /* >> * The reset command takes a long time to execute. >> */ >> timeout = msecs_to_jiffies(command == PS2_CMD_R

Re: Potential data race in psmouse_interrupt

2015-08-28 Thread Dmitry Torokhov
On Fri, Aug 28, 2015 at 10:34 AM, Dmitry Vyukov wrote: > Hello, > > I am looking at this code in __ps2_command again: > > /* > * The reset command takes a long time to execute. > */ > timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); > > timeout = wait_event_timeout(ps2dev->wa

Re: Potential data race in psmouse_interrupt

2015-08-28 Thread Dmitry Vyukov
Hello, I am looking at this code in __ps2_command again: /* * The reset command takes a long time to execute. */ timeout = msecs_to_jiffies(command == PS2_CMD_RESET_BAT ? 4000 : 500); timeout = wait_event_timeout(ps2dev->wait, !(READ_ONCE(ps2dev->flags) & PS2_FLAG_CMD1), timeout); if (smp_l

Re: Potential data race in psmouse_interrupt

2015-07-29 Thread Pali Rohár
Hi! This log looks like there can be race condition in initialization code, but not in receiving ALPS packets after initialization... On Thursday 23 July 2015 15:31:46 Andrey Konovalov wrote: > Hi Pali, > > There are a few reports in psmouse-base.c/alps.c code as well. > Here is a couple of them

Re: Potential data race in psmouse_interrupt

2015-07-23 Thread Andrey Konovalov
Hi Pali, There are a few reports in psmouse-base.c/alps.c code as well. Here is a couple of them that are printed one right after another. The second one tells about a race on ps2dev->cmdcnt. == ThreadSanitizer: data-race in ps2_hand

Re: Potential data race in psmouse_interrupt

2015-07-23 Thread Pali Rohár
On Wednesday 22 July 2015 15:14:42 Andrey Konovalov wrote: > Hi! > > We are working on a dynamic data race detector for Linux kernel called > KernelThreadSanitizer (ktsan) (https://github.com/google/ktsan/wiki). > > Here is a report we got while running ktsan (upstream revision > 21bdb584af8cca7c