Re: Re: [PATCH] media: vsp1: Fix runtime PM imbalance in vsp1_probe

2020-06-08 Thread Laurent Pinchart
Hi Geert, On Mon, Jun 08, 2020 at 09:39:51AM +0200, Geert Uytterhoeven wrote: > Hi Dinghao, > > On Mon, Jun 8, 2020 at 5:03 AM wrote: > > > > I wonder how many bugs we have today, and how many bugs will keep > > > > appearing in the future, due to this historical design mistake :-( > > > > Good

Re: Re: [PATCH] media: vsp1: Fix runtime PM imbalance in vsp1_probe

2020-06-08 Thread Geert Uytterhoeven
Hi Dinghao, On Mon, Jun 8, 2020 at 5:03 AM wrote: > > > I wonder how many bugs we have today, and how many bugs will keep > > > appearing in the future, due to this historical design mistake :-( > > Good question. It's hard to say if this is a design mistake (some use > of this API does not

Re: Re: Re: [PATCH] media: vsp1: Fix runtime PM imbalance in vsp1_probe

2020-06-07 Thread dinghao . liu
> > The vsp1_probe() function has a struct vsp1_device whose dev field is > populated by the time it needs to call pm_runtime_get_sync() and > pm_runtime_get_put(), so I think you can use vsp1_device_get() and > vsp1_device_put() as drop-in replacements without changing the > parameters to these

Re: Re: [PATCH] media: vsp1: Fix runtime PM imbalance in vsp1_probe

2020-06-07 Thread Laurent Pinchart
Hi Dianghao, On Mon, Jun 08, 2020 at 11:03:26AM +0800, dinghao@zju.edu.cn wrote: > Hi Laurent, > > > > I wonder how many bugs we have today, and how many bugs will keep > > > appearing in the future, due to this historical design mistake :-( > > Good question. It's hard to say if this is a

Re: Re: [PATCH] media: vsp1: Fix runtime PM imbalance in vsp1_probe

2020-06-07 Thread dinghao . liu
Hi Laurent, > > > > I wonder how many bugs we have today, and how many bugs will keep > > appearing in the future, due to this historical design mistake :-( > > Good question. It's hard to say if this is a design mistake (some use of this API does not check its return value and expects it