Re: Re: [PATCH V2] netfilter: h323: avoid potential attack

2016-01-28 Thread Zhouyi Zhou
Thanks for your advices. I will take your advice if I could have the opportunity to write the final code. As matter of factor, I trigger this bug when I tried to migrate H323 code to other operating systems. This could trigger a panic because get_h2x5_addr functions is the first time we ever try

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack

2016-01-28 Thread Eric Dumazet
On Thu, 2016-01-28 at 06:00 -0800, Eric Dumazet wrote: > On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote: > > > My patch is intend to prevent kernel panic, to prevent reading garbage > > or read data from a prior frame and leak secrets, the prototypes of the > > get_h2x5_addr functions and t

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack

2016-01-28 Thread Eric Dumazet
On Thu, 2016-01-28 at 21:14 +0800, Zhouyi Zhou wrote: > My patch is intend to prevent kernel panic, to prevent reading garbage > or read data from a prior frame and leak secrets, the prototypes of the > get_h2x5_addr functions and the functions that call get_h2x5_addr should > be changed, should

Re: Re: [PATCH V2] netfilter: h323: avoid potential attack

2016-01-28 Thread Zhouyi Zhou
Thanks Eric for replying > -Original Messages- > From: "Eric Dumazet" > Sent Time: Thursday, January 28, 2016 > To: "Zhouyi Zhou" > Cc: pa...@netfilter.org, ka...@trash.net, kad...@blackhole.kfki.hu, > da...@davemloft.net, netfilter-de...@vger.kernel.org, coret...@netfilter.org, > net..