Re: Recvfile patch used for Samba.

2013-07-25 Thread Dave Chinner
On Thu, Jul 25, 2013 at 09:17:01AM +0100, Steven Whitehouse wrote: > Hi, > > On Wed, 2013-07-24 at 12:47 +1000, Dave Chinner wrote: > > On Tue, Jul 23, 2013 at 02:58:58PM -0700, Jeremy Allison wrote: > > > Having said that the OEMs that are using it does > > > find it improves write speeds by a la

Re: Recvfile patch used for Samba.

2013-07-25 Thread Steven Whitehouse
Hi, On Wed, 2013-07-24 at 12:47 +1000, Dave Chinner wrote: > On Tue, Jul 23, 2013 at 02:58:58PM -0700, Jeremy Allison wrote: > > On Tue, Jul 23, 2013 at 05:10:27PM +1000, Dave Chinner wrote: > > > So, we are nesting up to 32 page locks here. That's bad. And we are > > > nesting kmap() calls for al

Re: Recvfile patch used for Samba.

2013-07-23 Thread Dave Chinner
On Tue, Jul 23, 2013 at 02:58:58PM -0700, Jeremy Allison wrote: > On Tue, Jul 23, 2013 at 05:10:27PM +1000, Dave Chinner wrote: > > So, we are nesting up to 32 page locks here. That's bad. And we are > > nesting kmap() calls for all the pages individually - is that even > > safe to do? > > > > So,

Re: Recvfile patch used for Samba.

2013-07-23 Thread Jeremy Allison
On Tue, Jul 23, 2013 at 05:10:27PM +1000, Dave Chinner wrote: > So, we are nesting up to 32 page locks here. That's bad. And we are > nesting kmap() calls for all the pages individually - is that even > safe to do? > > So, what happens when we've got 16 pages in, and the filesystem has > allocated

Re: Recvfile patch used for Samba.

2013-07-23 Thread Jeff Layton
On Tue, 23 Jul 2013 17:10:27 +1000 Dave Chinner wrote: > On Mon, Jul 22, 2013 at 02:57:38PM -0700, Jeremy Allison wrote: > > Hi Steve and Jeff (and others). > > > > Here is a patch that Samba vendors have been using > > to implement recvfile (copy directly from socket > > to file). It can improv

Re: Recvfile patch used for Samba.

2013-07-23 Thread Dave Chinner
On Mon, Jul 22, 2013 at 02:57:38PM -0700, Jeremy Allison wrote: > Hi Steve and Jeff (and others). > > Here is a patch that Samba vendors have been using > to implement recvfile (copy directly from socket > to file). It can improve write performance on boxes > by a significant amount (10% or more).

Re: Recvfile patch used for Samba.

2013-07-22 Thread Joe Perches
On Mon, 2013-07-22 at 14:57 -0700, Jeremy Allison wrote: > Here is a patch that Samba vendors have been using > to implement recvfile (copy directly from socket > to file). It can improve write performance on boxes > by a significant amount (10% or more). > > I'm not qualified to evaluate this cod