Re: Request for net guru help: waitqueue oops

2000-10-04 Thread Hans Grobler
On Wed, 4 Oct 2000, Petko Manolov wrote: > > The timer routines (there are 4) are used to switch hardware states and > > must therefore be mutually exclusive with respect to the interrupt handler. > > There are no bottom halves used in this driver. Andrew Morton suggested > > that the problem coul

Re: Request for net guru help: waitqueue oops

2000-10-04 Thread Petko Manolov
Hans Grobler wrote: > > Ok. I originally had them outside locks as they appeared to be atomic. I > moved them in incase they were the cause of the problem. Don't bother about them - see include/linux/netdevice.h to be sure. > The timer routines (there are 4) are used to switch hardware state

Re: Request for net guru help: waitqueue oops

2000-10-03 Thread Hans Grobler
On Tue, 3 Oct 2000, Petko Manolov wrote: > None of these can sleep. netif_*_queue routines are quite simple. > They are all atomic so there is no need to protect them with locks. Ok. I originally had them outside locks as they appeared to be atomic. I moved them in incase they were the cause of t

Re: Request for net guru help: waitqueue oops

2000-10-03 Thread Petko Manolov
Hans Grobler wrote: > > On Tue, 3 Oct 2000, Petko Manolov wrote: > > > It seems you're trying to sleep without process context (most likely in > > net_tx_action). It would be more clear if you send that part of the > > code. > > Since I don't explictly sleep anywhere, I'm not sure which code fra

Re: Request for net guru help: waitqueue oops

2000-10-03 Thread Hans Grobler
Hi Petkan, Thanks for your comment. On Tue, 3 Oct 2000, Petko Manolov wrote: > > A driver I'm working on seems to be doing/triggering something related > > to waitqueues. This causes a perfectly reproducable oops (small mercies!). > > Since the oops is not happening in my driver, I'm having a ha

Re: Request for net guru help: waitqueue oops

2000-10-03 Thread Petko Manolov
Hans Grobler wrote: > > Hi all, > > A driver I'm working on seems to be doing/triggering something related > to waitqueues. This causes a perfectly reproducable oops (small mercies!). > Since the oops is not happening in my driver, I'm having a hard time > figuring out whats going wrong. I suspe