Re: Where is the interrupt going?

2007-11-26 Thread Al Niessner
Yes, as also pointed out by Arjan Van de Ven, I was missing the pci_enable_device() call. This seems related to the deprecation of pci_find_device (or something like that) in favor of pci_get_device. Well, by adding the pci_enable_device it all works well. On Sat, 2007-11-24 at 08:53 +1100,

Re: Where is the interrupt going?

2007-11-26 Thread Al Niessner
Yes, as also pointed out by Arjan Van de Ven, I was missing the pci_enable_device() call. This seems related to the deprecation of pci_find_device (or something like that) in favor of pci_get_device. Well, by adding the pci_enable_device it all works well. On Sat, 2007-11-24 at 08:53 +1100,

Re: Where is the interrupt going?

2007-11-23 Thread Benjamin Herrenschmidt
On Wed, 2007-11-21 at 17:08 -0800, Al Niessner wrote: > > p8620 = pci_get_device (APC8620_VENDOR_ID, APC8620_DEVICE_ID, p8620); > <... fail if p8620 is 0 ...> > apcsi[i].ret_val = register_chrdev (MAJOR_NUM, > > DEVICE_NAME, > > _ops); > <... fail if ret_val < 0 ...> > apcsi[i].board_irq =

Re: Where is the interrupt going?

2007-11-23 Thread Alan Cox
On Fri, 23 Nov 2007 02:58:55 +0100 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Friday 23 November 2007, Alan Cox wrote: > > On Thu, 22 Nov 2007 16:48:53 -0800 > > [EMAIL PROTECTED] wrote: > > > > > > > > I tried the hammer and the problem persists. > > > > See my earlier email -

Re: Where is the interrupt going?

2007-11-23 Thread Jiri Slaby
On 11/23/2007 04:18 AM, Marin Mitov wrote: > request_irq returns EBUSY (not -EBUSY as should be) Because he writes -status to the output. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Where is the interrupt going?

2007-11-23 Thread Jiri Slaby
On 11/23/2007 04:18 AM, Marin Mitov wrote: request_irq returns EBUSY (not -EBUSY as should be) Because he writes -status to the output. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Where is the interrupt going?

2007-11-23 Thread Benjamin Herrenschmidt
On Wed, 2007-11-21 at 17:08 -0800, Al Niessner wrote: p8620 = pci_get_device (APC8620_VENDOR_ID, APC8620_DEVICE_ID, p8620); ... fail if p8620 is 0 ... apcsi[i].ret_val = register_chrdev (MAJOR_NUM, DEVICE_NAME, apc8620_ops); ... fail if ret_val 0 ... apcsi[i].board_irq = p8620-irq;

Re: Where is the interrupt going?

2007-11-23 Thread Alan Cox
On Fri, 23 Nov 2007 02:58:55 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Friday 23 November 2007, Alan Cox wrote: On Thu, 22 Nov 2007 16:48:53 -0800 [EMAIL PROTECTED] wrote: I tried the hammer and the problem persists. See my earlier email - your driver

Re: Where is the interrupt going?

2007-11-22 Thread niessner
Quite right. I read it too quickly and thought it had succeeded when it had failed. I will modify the module to do the shared IRQ and then try the noapic test again. Exactly why I reserved the right to do it again. This is good because it means the hammer may work after all. Thank you

Re: Where is the interrupt going?

2007-11-22 Thread Marin Mitov
Hi, On Friday 23 November 2007 02:48:53 am you wrote: > I tried the hammer and the problem persists. > [EMAIL PROTECTED]:~$ cat /proc/cmdline > root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash > > However, I reserve the right to try the hammer again in the future. > When I

Re: Where is the interrupt going?

2007-11-22 Thread Bartlomiej Zolnierkiewicz
On Friday 23 November 2007, Alan Cox wrote: > On Thu, 22 Nov 2007 16:48:53 -0800 > [EMAIL PROTECTED] wrote: > > > > > I tried the hammer and the problem persists. > > See my earlier email - your driver registers the irq with IRQF_DISABLED > then never enables it. As already explained by Kyle

Re: Where is the interrupt going?

2007-11-22 Thread Alan Cox
On Thu, 22 Nov 2007 16:48:53 -0800 [EMAIL PROTECTED] wrote: > > I tried the hammer and the problem persists. See my earlier email - your driver registers the irq with IRQF_DISABLED then never enables it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: Where is the interrupt going?

2007-11-22 Thread Robert Hancock
[EMAIL PROTECTED] wrote: I tried the hammer and the problem persists. [EMAIL PROTECTED]:~$ cat /proc/cmdline root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash However, I reserve the right to try the hammer again in the future. When I look at /proc/interrupts without the

Re: Where is the interrupt going?

2007-11-22 Thread niessner
I tried the hammer and the problem persists. [EMAIL PROTECTED]:~$ cat /proc/cmdline root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash However, I reserve the right to try the hammer again in the future. When I look at /proc/interrupts without the APIC: [EMAIL PROTECTED]:~$

Re: Where is the interrupt going?

2007-11-22 Thread niessner
I do not think so. I have printk (KERN_NOTICE ...) scattered throughout to make sure the ioctl() is succeeding and to print out registers on the hardware. Those are showing up in /var/log/messages without a hitch. If there is a setting for printk in interrupts, then maybe because I would

Re: Where is the interrupt going?

2007-11-22 Thread niessner
I do not think so. I have printk (KERN_NOTICE ...) scattered throughout to make sure the ioctl() is succeeding and to print out registers on the hardware. Those are showing up in /var/log/messages without a hitch. If there is a setting for printk in interrupts, then maybe because I would

Re: Where is the interrupt going?

2007-11-22 Thread niessner
I tried the hammer and the problem persists. [EMAIL PROTECTED]:~$ cat /proc/cmdline root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash However, I reserve the right to try the hammer again in the future. When I look at /proc/interrupts without the APIC: [EMAIL PROTECTED]:~$

Re: Where is the interrupt going?

2007-11-22 Thread Bartlomiej Zolnierkiewicz
On Friday 23 November 2007, Alan Cox wrote: On Thu, 22 Nov 2007 16:48:53 -0800 [EMAIL PROTECTED] wrote: I tried the hammer and the problem persists. See my earlier email - your driver registers the irq with IRQF_DISABLED then never enables it. As already explained by Kyle

Re: Where is the interrupt going?

2007-11-22 Thread niessner
Quite right. I read it too quickly and thought it had succeeded when it had failed. I will modify the module to do the shared IRQ and then try the noapic test again. Exactly why I reserved the right to do it again. This is good because it means the hammer may work after all. Thank you

Re: Where is the interrupt going?

2007-11-22 Thread Alan Cox
On Thu, 22 Nov 2007 16:48:53 -0800 [EMAIL PROTECTED] wrote: I tried the hammer and the problem persists. See my earlier email - your driver registers the irq with IRQF_DISABLED then never enables it. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: Where is the interrupt going?

2007-11-22 Thread Robert Hancock
[EMAIL PROTECTED] wrote: I tried the hammer and the problem persists. [EMAIL PROTECTED]:~$ cat /proc/cmdline root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash However, I reserve the right to try the hammer again in the future. When I look at /proc/interrupts without the

Re: Where is the interrupt going?

2007-11-22 Thread Marin Mitov
Hi, On Friday 23 November 2007 02:48:53 am you wrote: I tried the hammer and the problem persists. [EMAIL PROTECTED]:~$ cat /proc/cmdline root=UUID=8b3c3666-22c3-4c04-b399-ece266f2ef30 ro noapic quiet splash However, I reserve the right to try the hammer again in the future. When I look at

Re: Where is the interrupt going?

2007-11-21 Thread Arjan van de Ven
On Wed, 21 Nov 2007 17:08:30 -0800 Al Niessner <[EMAIL PROTECTED]> wrote: > > Lastly, I would be happy to give out the entire module to anyone who > requests it, but it is about 550 lines so I did not want to attach it > to this already long post. > can you send it to me, or even better, post

Re: Where is the interrupt going?

2007-11-21 Thread Kyle McMartin
On Wed, Nov 21, 2007 at 05:08:30PM -0800, Al Niessner wrote: > On with the detailed technical information. I developed a kernel module > for an PCI card back in 2.4, moved it to 2.6.3, then 2.6.11 or so and > now I am trying to move it to 2.6.22. When I began the to move to > 2.6.22, I changed all

Re: Where is the interrupt going?

2007-11-21 Thread Jesper Juhl
On 22/11/2007, Al Niessner <[EMAIL PROTECTED]> wrote: > > Quickly stated, I have a piece of hardware on the PCI bus that is > generating an interrupt (can watch it with a scope) but my handler is > not being called (no printk in /var/log/messages). So, where has the > interrupt gone? > Just to

Re: Where is the interrupt going?

2007-11-21 Thread Kyle McMartin
On Thu, Nov 22, 2007 at 01:56:25AM +, Alan Cox wrote: > > status = request_irq (apcsi[i].board_irq, > > apc8620_handler, > > IRQF_DISABLED, > > You set IRQF_DISABLED > > Do you then enable the interrupt anywhere

Re: Where is the interrupt going?

2007-11-21 Thread Alan Cox
> status = request_irq (apcsi[i].board_irq, > apc8620_handler, > IRQF_DISABLED, You set IRQF_DISABLED Do you then enable the interrupt anywhere later on ? Alan - To unsubscribe from this list: send the line "unsubscribe

Re: Where is the interrupt going?

2007-11-21 Thread Alan Cox
status = request_irq (apcsi[i].board_irq, apc8620_handler, IRQF_DISABLED, You set IRQF_DISABLED Do you then enable the interrupt anywhere later on ? Alan - To unsubscribe from this list: send the line unsubscribe

Re: Where is the interrupt going?

2007-11-21 Thread Kyle McMartin
On Thu, Nov 22, 2007 at 01:56:25AM +, Alan Cox wrote: status = request_irq (apcsi[i].board_irq, apc8620_handler, IRQF_DISABLED, You set IRQF_DISABLED Do you then enable the interrupt anywhere later on ?

Re: Where is the interrupt going?

2007-11-21 Thread Kyle McMartin
On Wed, Nov 21, 2007 at 05:08:30PM -0800, Al Niessner wrote: On with the detailed technical information. I developed a kernel module for an PCI card back in 2.4, moved it to 2.6.3, then 2.6.11 or so and now I am trying to move it to 2.6.22. When I began the to move to 2.6.22, I changed all of

Re: Where is the interrupt going?

2007-11-21 Thread Jesper Juhl
On 22/11/2007, Al Niessner [EMAIL PROTECTED] wrote: Quickly stated, I have a piece of hardware on the PCI bus that is generating an interrupt (can watch it with a scope) but my handler is not being called (no printk in /var/log/messages). So, where has the interrupt gone? Just to rule out

Re: Where is the interrupt going?

2007-11-21 Thread Arjan van de Ven
On Wed, 21 Nov 2007 17:08:30 -0800 Al Niessner [EMAIL PROTECTED] wrote: Lastly, I would be happy to give out the entire module to anyone who requests it, but it is about 550 lines so I did not want to attach it to this already long post. can you send it to me, or even better, post it