Re: blk: improve order of bio handling in generic_make_request()

On Wed, Mar 08 2017, Mikulas Patocka wrote: > On Wed, 8 Mar 2017, NeilBrown wrote: >> >> I don't think this will fix the DM snapshot deadlock by itself. >> Rather, it make it possible for some internal changes to DM to fix it. >> The DM change might be something vaguely like: >> >> diff --git

Re: blk: improve order of bio handling in generic_make_request()

On Wed, Mar 08 2017, Mikulas Patocka wrote: > On Wed, 8 Mar 2017, NeilBrown wrote: >> >> I don't think this will fix the DM snapshot deadlock by itself. >> Rather, it make it possible for some internal changes to DM to fix it. >> The DM change might be something vaguely like: >> >> diff --git

Re: blk: improve order of bio handling in generic_make_request()

On 8 March 2017 at 17:40, Mikulas Patocka wrote: > > On Wed, 8 Mar 2017, NeilBrown wrote: > > I don't think this will fix the DM snapshot deadlock by itself. > > Rather, it make it possible for some internal changes to DM to fix it. > > The DM change might be something

Re: blk: improve order of bio handling in generic_make_request()

On 8 March 2017 at 17:40, Mikulas Patocka wrote: > > On Wed, 8 Mar 2017, NeilBrown wrote: > > I don't think this will fix the DM snapshot deadlock by itself. > > Rather, it make it possible for some internal changes to DM to fix it. > > The DM change might be something vaguely like: > > > > diff

Re: blk: improve order of bio handling in generic_make_request()

On Wed, 8 Mar 2017, NeilBrown wrote: > On Tue, Mar 07 2017, Mike Snitzer wrote: > > > On Tue, Mar 07 2017 at 12:05pm -0500, > > Jens Axboe wrote: > > > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: > >> > On Tue, Mar 07 2017 at 3:49am -0500, > >> > Jack Wang

Re: blk: improve order of bio handling in generic_make_request()

On Wed, 8 Mar 2017, NeilBrown wrote: > On Tue, Mar 07 2017, Mike Snitzer wrote: > > > On Tue, Mar 07 2017 at 12:05pm -0500, > > Jens Axboe wrote: > > > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: > >> > On Tue, Mar 07 2017 at 3:49am -0500, > >> > Jack Wang wrote: > >> > > >> >> > >> >>

Re: blk: improve order of bio handling in generic_make_request()

On 7 March 2017 at 17:52, Mike Snitzer wrote: > > On 06.03.2017 21:18, Jens Axboe wrote: > > > I like the change, and thanks for tackling this. It's been a pending > > > issue for way too long. I do think we should squash Jack's patch > > > into the original, as it does clean

Re: blk: improve order of bio handling in generic_make_request()

On 7 March 2017 at 17:52, Mike Snitzer wrote: > > On 06.03.2017 21:18, Jens Axboe wrote: > > > I like the change, and thanks for tackling this. It's been a pending > > > issue for way too long. I do think we should squash Jack's patch > > > into the original, as it does clean up the code nicely.

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 3:29pm -0500, NeilBrown wrote: > On Tue, Mar 07 2017, Mike Snitzer wrote: > > > On Tue, Mar 07 2017 at 12:05pm -0500, > > Jens Axboe wrote: > > > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: > >> > > >> > In addition to Jack's MD raid

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 3:29pm -0500, NeilBrown wrote: > On Tue, Mar 07 2017, Mike Snitzer wrote: > > > On Tue, Mar 07 2017 at 12:05pm -0500, > > Jens Axboe wrote: > > > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: > >> > > >> > In addition to Jack's MD raid test there is a DM snapshot

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017, Mike Snitzer wrote: > On Tue, Mar 07 2017 at 12:05pm -0500, > Jens Axboe wrote: > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: >> > On Tue, Mar 07 2017 at 3:49am -0500, >> > Jack Wang wrote: >> > >> >> >> >> >> >> On

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017, Mike Snitzer wrote: > On Tue, Mar 07 2017 at 12:05pm -0500, > Jens Axboe wrote: > >> On 03/07/2017 09:52 AM, Mike Snitzer wrote: >> > On Tue, Mar 07 2017 at 3:49am -0500, >> > Jack Wang wrote: >> > >> >> >> >> >> >> On 06.03.2017 21:18, Jens Axboe wrote: >> >>> On

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 3:49am -0500, Jack Wang wrote: > > > On 06.03.2017 21:18, Jens Axboe wrote: > > On 03/05/2017 09:40 PM, NeilBrown wrote: > >> On Fri, Mar 03 2017, Jack Wang wrote: > >>> > >>> Thanks Neil for pushing the fix. > >>> > >>> We can optimize

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 3:49am -0500, Jack Wang wrote: > > > On 06.03.2017 21:18, Jens Axboe wrote: > > On 03/05/2017 09:40 PM, NeilBrown wrote: > >> On Fri, Mar 03 2017, Jack Wang wrote: > >>> > >>> Thanks Neil for pushing the fix. > >>> > >>> We can optimize generic_make_request a little

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 12:05pm -0500, Jens Axboe wrote: > On 03/07/2017 09:52 AM, Mike Snitzer wrote: > > On Tue, Mar 07 2017 at 3:49am -0500, > > Jack Wang wrote: > > > >> > >> > >> On 06.03.2017 21:18, Jens Axboe wrote: > >>> On 03/05/2017 09:40

Re: blk: improve order of bio handling in generic_make_request()

On Tue, Mar 07 2017 at 12:05pm -0500, Jens Axboe wrote: > On 03/07/2017 09:52 AM, Mike Snitzer wrote: > > On Tue, Mar 07 2017 at 3:49am -0500, > > Jack Wang wrote: > > > >> > >> > >> On 06.03.2017 21:18, Jens Axboe wrote: > >>> On 03/05/2017 09:40 PM, NeilBrown wrote: > On Fri, Mar 03

Re: blk: improve order of bio handling in generic_make_request()

On 03/07/2017 09:52 AM, Mike Snitzer wrote: > On Tue, Mar 07 2017 at 3:49am -0500, > Jack Wang wrote: > >> >> >> On 06.03.2017 21:18, Jens Axboe wrote: >>> On 03/05/2017 09:40 PM, NeilBrown wrote: On Fri, Mar 03 2017, Jack Wang wrote: > > Thanks Neil

Re: blk: improve order of bio handling in generic_make_request()

On 03/07/2017 09:52 AM, Mike Snitzer wrote: > On Tue, Mar 07 2017 at 3:49am -0500, > Jack Wang wrote: > >> >> >> On 06.03.2017 21:18, Jens Axboe wrote: >>> On 03/05/2017 09:40 PM, NeilBrown wrote: On Fri, Mar 03 2017, Jack Wang wrote: > > Thanks Neil for pushing the fix. >