Re: checkpatch: support deprecated terms checking

2020-07-27 Thread SeongJae Park
On Mon, 27 Jul 2020 13:49:00 -0700 Joe Perches wrote: > On Mon, 2020-07-27 at 13:44 -0700, Andrew Morton wrote: > > On Mon, 27 Jul 2020 08:54:41 +0200 SeongJae Park wrote: > > > > > > > > Unfortunately, the inexperienced _do_ in fact run > > > > > > checkpatch on files and submit inappropriate

Re: checkpatch: support deprecated terms checking

2020-07-27 Thread Joe Perches
On Mon, 2020-07-27 at 13:44 -0700, Andrew Morton wrote: > On Mon, 27 Jul 2020 08:54:41 +0200 SeongJae Park wrote: > > > > > > Unfortunately, the inexperienced _do_ in fact run > > > > > checkpatch on files and submit inappropriate patches. > > I don't think I really agree with the "new code only

Re: checkpatch: support deprecated terms checking

2020-07-27 Thread Andrew Morton
On Mon, 27 Jul 2020 08:54:41 +0200 SeongJae Park wrote: > > > > Unfortunately, the inexperienced _do_ in fact run > > > > checkpatch on files and submit inappropriate patches. I don't think I really agree with the "new code only" guideline (where did this come from, anyway?). 10 years from now

Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sun, 26 Jul 2020 22:33:28 +0200 "Michał Mirosław" wrote: > On Sun, Jul 26, 2020 at 08:07:48PM +0200, SeongJae Park wrote: > > On Sun, 26 Jul 2020 09:42:06 -0700 Joe Perches wrote: > > > > > On Sun, 2020-07-26 at 17:36 +0200, SeongJae Park wrote: > > > > On Sun, 26 Jul 2020 07:50:54 -0700 Jo

Re: checkpatch: support deprecated terms checking

2020-07-26 Thread Michał Mirosław
On Sun, Jul 26, 2020 at 08:07:48PM +0200, SeongJae Park wrote: > On Sun, 26 Jul 2020 09:42:06 -0700 Joe Perches wrote: > > > On Sun, 2020-07-26 at 17:36 +0200, SeongJae Park wrote: > > > On Sun, 26 Jul 2020 07:50:54 -0700 Joe Perches wrote: > > [] > > > > I do not want to encourage relatively in

Re: Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sun, 26 Jul 2020 09:42:06 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 17:36 +0200, SeongJae Park wrote: > > On Sun, 26 Jul 2020 07:50:54 -0700 Joe Perches wrote: > [] > > > I do not want to encourage relatively inexperienced people > > > to run checkpatch and submit inappropriate patches

Re: Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread Joe Perches
On Sun, 2020-07-26 at 17:36 +0200, SeongJae Park wrote: > On Sun, 26 Jul 2020 07:50:54 -0700 Joe Perches wrote: [] > > I do not want to encourage relatively inexperienced people > > to run checkpatch and submit inappropriate patches. > > Me, neither. But, I think providing more warnings and refe

Re: Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sun, 26 Jul 2020 07:50:54 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 09:45 +0200, SeongJae Park wrote: > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > [] > > @@ -721,6 +721,7 @@ sub read_word_corrections { > > my %deprecated_terms_fix; > > read_word_corrections($deprec

Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread Joe Perches
On Sun, 2020-07-26 at 09:45 +0200, SeongJae Park wrote: > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -721,6 +721,7 @@ sub read_word_corrections { > my %deprecated_terms_fix; > read_word_corrections($deprecated_terms_file, \%deprecated_terms_fix); > my $deprecated_terms =

Re: Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sun, 26 Jul 2020 00:29:05 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 09:18 +0200, SeongJae Park wrote: > > On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > > > > > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wro

Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread Joe Perches
On Sun, 2020-07-26 at 09:18 +0200, SeongJae Park wrote: > On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > > > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > > > > > > > On Sat, 2020-07-25 at 15:02 +0200, Michał Miros

Re: Re: Re: checkpatch: support deprecated terms checking

2020-07-26 Thread SeongJae Park
On Sat, 25 Jul 2020 21:27:07 -0700 Joe Perches wrote: > On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > > > > > On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > > > > Hello, > > > > > > > > I see that this patch wen

Re: Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Joe Perches
On Sun, 2020-07-26 at 01:35 +0200, SeongJae Park wrote: > On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > > > On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > > > Hello, > > > > > > I see that this patch went into next and is already inciting people to > > > do wrong things [1

Re: Re: checkpatch: support deprecated terms checking

2020-07-25 Thread SeongJae Park
On Sat, 25 Jul 2020 10:29:23 -0700 Joe Perches wrote: > On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > > Hello, > > > > I see that this patch went into next and is already inciting people to > > do wrong things [1]. Can you please fix it to require '--subjective' > > switch or other

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Joe Perches
On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > Hello, > > I see that this patch went into next and is already inciting people to > do wrong things [1]. Can you please fix it to require '--subjective' > switch or otherwise mark it clearly as suggestion-only? > > The coding-style as in

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Joe Perches
On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > Hello, > > I see that this patch went into next and is already inciting people to > do wrong things [1]. Can you please fix it to require '--subjective' > switch or otherwise mark it clearly as suggestion-only? > > The coding-style as in

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Michał Mirosław
Hello, I see that this patch went into next and is already inciting people to do wrong things [1]. Can you please fix it to require '--subjective' switch or otherwise mark it clearly as suggestion-only? The coding-style as in Linus' master says about *NEW* uses of the words listed (those introduc