Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Greg Kroah-Hartman
On Sat, Feb 13, 2021 at 07:02:22PM +0900, Tetsuo Handa wrote: > Greg, will you queue > https://lkml.kernel.org/r/20210205135707.4574-1-penguin-ker...@i-love.sakura.ne.jp > (which can > close a report which is wasting syzbot's resource with 5300+ crashes) for > 5.12 ? The change shown below will

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Greg Kroah-Hartman
On Sat, Feb 13, 2021 at 07:02:22PM +0900, Tetsuo Handa wrote: > Greg, will you queue > https://lkml.kernel.org/r/20210205135707.4574-1-penguin-ker...@i-love.sakura.ne.jp > (which can > close a report which is wasting syzbot's resource with 5300+ crashes) for > 5.12 ? The change shown below will

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-13 Thread Tetsuo Handa
Greg, will you queue https://lkml.kernel.org/r/20210205135707.4574-1-penguin-ker...@i-love.sakura.ne.jp (which can close a report which is wasting syzbot's resource with 5300+ crashes) for 5.12 ? The change shown below will be too large to test before merge window for 5.12 opens. The patch for

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-12 Thread Shuah Khan
On 2/11/21 9:58 PM, Tetsuo Handa wrote: On 2021/02/12 11:22, Tetsuo Handa wrote: On 2021/02/12 10:34, Shuah Khan wrote: On 2/10/21 6:14 PM, Tetsuo Handa wrote: (Dropping LSM ML because this is not a TOMOYO's bug.) On 2021/02/11 4:29, Shuah Khan wrote: This is a good find. I already replied t

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Tetsuo Handa
On 2021/02/12 11:22, Tetsuo Handa wrote: > On 2021/02/12 10:34, Shuah Khan wrote: >> On 2/10/21 6:14 PM, Tetsuo Handa wrote: >>> (Dropping LSM ML because this is not a TOMOYO's bug.) >>> >>> On 2021/02/11 4:29, Shuah Khan wrote: This is a good find. I already replied to the thread to send a co

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Tetsuo Handa
On 2021/02/12 10:34, Shuah Khan wrote: > On 2/10/21 6:14 PM, Tetsuo Handa wrote: >> (Dropping LSM ML because this is not a TOMOYO's bug.) >> >> On 2021/02/11 4:29, Shuah Khan wrote: >>> This is a good find. I already replied to the thread to send a complete >>> fix. >> >> As I said at >> https://l

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-11 Thread Shuah Khan
On 2/10/21 6:14 PM, Tetsuo Handa wrote: (Dropping LSM ML because this is not a TOMOYO's bug.) On 2021/02/11 4:29, Shuah Khan wrote: This is a good find. I already replied to the thread to send a complete fix. As I said at https://lkml.kernel.org/r/f8cae6b1-8f84-0e6a-7d9c-fc4aec68f...@i-love.

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Tetsuo Handa
(Dropping LSM ML because this is not a TOMOYO's bug.) On 2021/02/11 4:29, Shuah Khan wrote: > This is a good find. I already replied to the thread to send a complete > fix. As I said at https://lkml.kernel.org/r/f8cae6b1-8f84-0e6a-7d9c-fc4aec68f...@i-love.sakura.ne.jp , the as-is patch is effec

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Shuah Khan
On 2/10/21 12:07 PM, Tetsuo Handa wrote: On 2021/02/11 3:17, Shuah Khan wrote: I am looking to understand the syzbot configuration and a reproducer to be able to debug and fix the problem. How is syzbot triggering the vhci_hcd attach and detach sequence? I don't know. I'm waiting for syzbot to

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Tetsuo Handa
On 2021/02/11 3:17, Shuah Khan wrote: > I am looking to understand the syzbot configuration and a reproducer > to be able to debug and fix the problem. How is syzbot triggering the > vhci_hcd attach and detach sequence? I don't know. I'm waiting for syzbot to reproduce the problem on linux-next wi

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-02-10 Thread Shuah Khan
On 1/29/21 7:25 PM, Tetsuo Handa wrote: On 2021/01/30 6:18, Shuah Khan wrote: In this console log: It seems "this console log" refers to https://syzkaller.appspot.com/x/log.txt?x=1045303450 . 06:57:50 executing program 1: socketpair$tipc(0x1e, 0x2, 0x0, &(0x7fc0)={0xfff

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-30 Thread Tetsuo Handa
On 2021/01/30 6:18, Shuah Khan wrote: > In this console log: It seems "this console log" refers to https://syzkaller.appspot.com/x/log.txt?x=1045303450 . > > 06:57:50 executing program 1: > socketpair$tipc(0x1e, 0x2, 0x0, &(0x7fc0)={0x}) > sendmsg$BATADV_CMD_GET_TRAN

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-29 Thread Shuah Khan
On 1/29/21 10:08 AM, Tetsuo Handa wrote: On 2021/01/30 1:05, Shuah Khan wrote: Since "general protection fault in tomoyo_socket_sendmsg_permission" is caused by unexpectedly resetting ud->tcp_socket to NULL without waiting for tx thread to terminate, tracing the ordering of events is worth know

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-29 Thread Tetsuo Handa
On 2021/01/30 1:05, Shuah Khan wrote: >> Since "general protection fault in tomoyo_socket_sendmsg_permission" is >> caused by >> unexpectedly resetting ud->tcp_socket to NULL without waiting for tx thread >> to >> terminate, tracing the ordering of events is worth knowing. Even adding >> schedule

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-28 Thread Tetsuo Handa
On 2021/01/29 4:05, Shuah Khan wrote: > The reason I don't like adding printk's is this is a race condition > and as a result time sensitive. Adding printks in the path will not > help debug this issue. It will make it harder to reproduce the problem. Not always. Adding printk() might make it easi

Re: general protection fault in tomoyo_socket_sendmsg_permission

2021-01-27 Thread Tetsuo Handa
On 2020/11/14 2:14, Shuah Khan wrote: > On 11/13/20 5:00 AM, Hillf Danton wrote: >> Thu, 12 Nov 2020 23:21:26 -0800 >>> syzbot found the following issue on: >>> >>> HEAD commit:    9dbc1c03 Merge tag 'xfs-5.10-fixes-3' of git://git.kernel... >>> git tree:   upstream >>> console output: https://

Re: general protection fault in tomoyo_socket_sendmsg_permission

2020-11-13 Thread Shuah Khan
On 11/13/20 5:00 AM, Hillf Danton wrote: Thu, 12 Nov 2020 23:21:26 -0800 syzbot found the following issue on: HEAD commit:9dbc1c03 Merge tag 'xfs-5.10-fixes-3' of git://git.kernel... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1045303450 kernel con