On Tue, Feb 10, 2015 at 2:38 AM, Robert Jarzmik wrote:
> Tyler Hall writes:
>
>>> The issue with multiple gpiochips per of-node could be worked around as
>>> followed I believe, comments?
>>>
>>> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
>>> index 08261f2..43984ab 100644
Tyler Hall writes:
>> The issue with multiple gpiochips per of-node could be worked around as
>> followed I believe, comments?
>>
>> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
>> index 08261f2..43984ab 100644
>> --- a/drivers/gpio/gpiolib-of.c
>> +++ b/drivers/gpio/gpioli
> The issue with multiple gpiochips per of-node could be worked around as
> followed I believe, comments?
>
> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 08261f2..43984ab 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
> @@ -47,11 +47,12 @@
> > 1. Require child nodes in DT for each bank
>
> This would break DT compatibility.
>
> > 2. Refactor gpio-pxa to only register one gpiochip
>
> Sounds better, especially since this would reflect the hardware more
> accurately. One DT node should translate into one GPIO chip. The problem is
>
Alexandre Courbot writes:
> Adding Robert who reported the same thing.
>
> On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall wrote:
>> 1. Require child nodes in DT for each bank
>
> This would break DT compatibility.
Agreed.
>
>> 2. Refactor gpio-pxa to only register one gpiochip
>
> Sounds better, es
Adding Robert who reported the same thing.
On Sat, Feb 7, 2015 at 6:28 AM, Tyler Hall wrote:
> Hi,
>
> Commit 7b8792b ("gpiolib: of: Correct error handling in
> of_get_named_gpiod_flags") seems to break the ability to use DT
> bindings to reference this driver's GPIOs by phandle for banks above
>
6 matches
Mail list logo
