Re: gpio-ucb1400

2013-04-10 Thread Linus Walleij
On Tue, Apr 2, 2013 at 9:22 AM, Jean Delvare wrote: > Well Marek proposed a cleanup which looked good [1], several times > apparently, but it was never applied. > > [1] > http://lists.infradead.org/pipermail/linux-arm-kernel/2010-October/028656.html Marek, could you rebase and repost this and s

Re: gpio-ucb1400

2013-04-02 Thread Mark Brown
On Tue, Apr 02, 2013 at 09:22:37AM +0200, Jean Delvare wrote: > Le lundi 01 avril 2013 à 16:32 +0100, Mark Brown a écrit : > > What the driver is doing is, unfortunately, the best practice for an > > AC'97 connected device like this - we've got an uncomfortable mix of > > an enumerable bus and pla

Re: gpio-ucb1400

2013-04-02 Thread Jean Delvare
Le lundi 01 avril 2013 à 16:32 +0100, Mark Brown a écrit : > On Mon, Apr 01, 2013 at 01:06:43PM +0200, Jean Delvare wrote: > > > My point was, the upstream gpio-ucb1400 driver in its current form is > > unusable (on top of being ugly.) I have no doubt that someone used that > > driver successfully

Re: gpio-ucb1400

2013-04-01 Thread Mark Brown
On Mon, Apr 01, 2013 at 01:06:43PM +0200, Jean Delvare wrote: > My point was, the upstream gpio-ucb1400 driver in its current form is > unusable (on top of being ugly.) I have no doubt that someone used that > driver successfully in some external kernel tree, but the code that was > merged upstrea

Re: gpio-ucb1400

2013-04-01 Thread Jean Delvare
Le dimanche 31 mars 2013 à 19:19 +0200, Marek Vasut a écrit : > Dear Guenter Roeck, > > Jean is absolutely right - it should get fixed, or the driver should be > > dropped if no one is using it anyway. > > I think ARM/palmtc was using this. My point was, the upstream gpio-ucb1400 driver in its cu

Re: gpio-ucb1400

2013-03-31 Thread Marek Vasut
Dear Guenter Roeck, > On Sat, Mar 30, 2013 at 08:20:44PM +0100, Marek Vasut wrote: > > Dear Guenter Roeck, > > > > > On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: > > > > Hi all, > > > > > > > > In September 2009, a driver for the GPIO function of the UCB1400 chip > > > > was add

Re: gpio-ucb1400

2013-03-30 Thread Guenter Roeck
On Sat, Mar 30, 2013 at 08:20:44PM +0100, Marek Vasut wrote: > Dear Guenter Roeck, > > > On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: > > > Hi all, > > > > > > In September 2009, a driver for the GPIO function of the UCB1400 chip > > > was added to the kernel tree. The probe func

Re: gpio-ucb1400

2013-03-30 Thread Marek Vasut
Dear Guenter Roeck, > On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: > > Hi all, > > > > In September 2009, a driver for the GPIO function of the UCB1400 chip > > was added to the kernel tree. The probe function of this driver requires > > ucbdata to be set. The only place where th

Re: gpio-ucb1400

2013-03-30 Thread Guenter Roeck
On Fri, Mar 29, 2013 at 08:46:39PM +0100, Jean Delvare wrote: > Hi all, > > In September 2009, a driver for the GPIO function of the UCB1400 chip > was added to the kernel tree. The probe function of this driver requires > ucbdata to be set. The only place where this happens is in function > ucb14