Re: include/linux/pcounter.h

2008-02-26 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Sat, 16 Feb 2008 11:26:18 -0800 > > > On Sat, 16 Feb 2008 13:03:54 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > > > Yes, per connection basis. Some workloads want to open/close more > > > than 10

Re: include/linux/pcounter.h

2008-02-16 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Sat, 16 Feb 2008 11:26:18 -0800 > On Sat, 16 Feb 2008 13:03:54 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > Yes, per connection basis. Some workloads want to open/close more than 1000 > > sockets per second. > > ie: slowpath Definitely not s

Re: include/linux/pcounter.h

2008-02-16 Thread Arjan van de Ven
On Sat, 16 Feb 2008 11:26:18 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > > indirect functions calls are everywhere in kernel, network, fs, > > everywhere. > > That doesn't make them fast. just to emphasize this: an indirect function call is at least as expensive as an atomic operation on

Re: include/linux/pcounter.h

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 13:03:54 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > Andrew Morton a écrit : > > On Sat, 16 Feb 2008 11:07:29 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > >> Andrew, pcounter is a temporary abstraction. > > > > It's buggy! Main problems are a) possible return of n

Re: include/linux/pcounter.h

2008-02-16 Thread Eric Dumazet
Andrew Morton a écrit : On Sat, 16 Feb 2008 11:07:29 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: Andrew, pcounter is a temporary abstraction. It's buggy! Main problems are a) possible return of negative numbers b) some of the API can't be from preemptible code c) excessive interrupt-off ti

Re: include/linux/pcounter.h

2008-02-16 Thread Andrew Morton
On Sat, 16 Feb 2008 11:07:29 +0100 Eric Dumazet <[EMAIL PROTECTED]> wrote: > > Andrew, pcounter is a temporary abstraction. It's buggy! Main problems are a) possible return of negative numbers b) some of the API can't be from preemptible code c) excessive interrupt-off time on some machines if

Re: include/linux/pcounter.h

2008-02-16 Thread Eric Dumazet
Andrew Morton a écrit : - First up, why was this added at all? We have percpu_counter.h which has several years development invested in it. afaict it would suit the present applications of pcounters. If some deficiency in percpu_counters has been identified, is it possible to correct t

Re: include/linux/pcounter.h

2008-02-15 Thread Andrew Morton
- First up, why was this added at all? We have percpu_counter.h which has several years development invested in it. afaict it would suit the present applications of pcounters. If some deficiency in percpu_counters has been identified, is it possible to correct that deficiency rather tha

Re: include/linux/pcounter.h

2008-02-04 Thread Andrew Morton
On Mon, 04 Feb 2008 16:20:35 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Mon, 4 Feb 2008 01:44:02 -0800 > > > Please do not merge pieces of generic kernel infrastructure while > > keeping it all secret on the netdev list. Ever. > > It wa

Re: include/linux/pcounter.h

2008-02-04 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Mon, 4 Feb 2008 01:44:02 -0800 > Please do not merge pieces of generic kernel infrastructure while > keeping it all secret on the netdev list. Ever. It was so damn secret that it sat in your -mm tree for months. Don't be rediculious Andrew. -- To un