Re: kmod: add a sanity check on module loading

2017-01-09 Thread Luis R. Rodriguez
On Fri, Jan 06, 2017 at 04:53:54PM -0500, Jessica Yu wrote: > +++ Luis R. Rodriguez [06/01/17 21:36 +0100]: > > On Tue, Jan 03, 2017 at 10:34:53AM +1030, Rusty Russell wrote: > > > "Luis R. Rodriguez" writes: > > > > Right, out of ~350 request_module() calls (not included try requests) > > > > onl

Re: kmod: add a sanity check on module loading

2017-01-06 Thread Jessica Yu
+++ Luis R. Rodriguez [06/01/17 21:36 +0100]: On Tue, Jan 03, 2017 at 10:34:53AM +1030, Rusty Russell wrote: "Luis R. Rodriguez" writes: > Right, out of ~350 request_module() calls (not included try requests) > only ~46 check the return value. Hence a validation check, and come to > think of it

Re: kmod: add a sanity check on module loading

2017-01-06 Thread Jessica Yu
+++ Rusty Russell [03/01/17 10:34 +1030]: "Luis R. Rodriguez" writes: Maybe a similar hack for try_then_request_module(), but many places seem to open-code request_module() so it's not as trivial... Hi Luis, Jessica (who is the main module maintainer now), Back from break, sorry about

Re: kmod: add a sanity check on module loading

2017-01-03 Thread Jessica Yu
+++ Luis R. Rodriguez [08/12/16 11:49 -0800]: kmod has an optimization in place whereby if a some kernel code uses request_module() on a module already loaded we never bother userspace as the module already is loaded. This is not true for get_fs_type() though as it uses aliases. Additionally kmo