Re: linux-next: build failure after merge of the xarray tree

2020-10-08 Thread Matthew Wilcox
On Thu, Oct 08, 2020 at 05:55:40PM +1100, Stephen Rothwell wrote: > After merging the xarray tree, today's linux-next build (x86_64 > allmodconfig) failed like this: Thanks, fixed both problems.

Re: linux-next: build failure after merge of the xarray tree

2019-03-11 Thread Jason Gunthorpe
On Mon, Mar 11, 2019 at 05:31:05AM -0700, Matthew Wilcox wrote: > On Mon, Mar 11, 2019 at 12:13:54PM +, Jason Gunthorpe wrote: > > > @@ -1059,14 +1050,14 @@ static int assign_client_id(struct ib_client > > > *client) > > >* to get the LIFO order. The extra linked list can go away if xarray

Re: linux-next: build failure after merge of the xarray tree

2019-03-11 Thread Leon Romanovsky
On Sun, Mar 10, 2019 at 07:44:34PM -0700, Matthew Wilcox wrote: > On Thu, Feb 21, 2019 at 12:34:42PM +, Leon Romanovsky wrote: > > On Thu, Feb 21, 2019 at 05:13:32PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the xarray tree, today's linux-next build (powerpc > > > p

Re: linux-next: build failure after merge of the xarray tree

2019-03-11 Thread Matthew Wilcox
On Mon, Mar 11, 2019 at 12:13:54PM +, Jason Gunthorpe wrote: > > @@ -1059,14 +1050,14 @@ static int assign_client_id(struct ib_client > > *client) > > * to get the LIFO order. The extra linked list can go away if xarray > > * learns to reverse iterate. > > */ > > - if (list_em

Re: linux-next: build failure after merge of the xarray tree

2019-03-11 Thread Jason Gunthorpe
On Sun, Mar 10, 2019 at 07:44:34PM -0700, Matthew Wilcox wrote: > On Thu, Feb 21, 2019 at 12:34:42PM +, Leon Romanovsky wrote: > > On Thu, Feb 21, 2019 at 05:13:32PM +1100, Stephen Rothwell wrote: > > > Hi all, > > > > > > After merging the xarray tree, today's linux-next build (powerpc > > > p

Re: linux-next: build failure after merge of the xarray tree

2019-03-10 Thread Matthew Wilcox
On Thu, Feb 21, 2019 at 12:34:42PM +, Leon Romanovsky wrote: > On Thu, Feb 21, 2019 at 05:13:32PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > After merging the xarray tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: [API change] So I ended up being really

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Jason Gunthorpe
On Thu, Feb 21, 2019 at 11:47:16PM +1100, Stephen Rothwell wrote: > Hi Jason, > > On Wed, 13 Feb 2019 22:09:36 + Jason Gunthorpe wrote: > > > > I personally think it is not good to put major logic changes in merge > > commits, so I would prefer the #2 approach for this case. > > These are no

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Stephen Rothwell
Hi Leon, On Thu, 21 Feb 2019 13:16:31 + Leon Romanovsky wrote: > > > The xarray API changes (to xa_alloc and __xa_alloc) have been in > > linux-next for about 2 weeks ... > > I looked on the latest update of pulled branch > http://git.infradead.org/users/willy/linux-dax.git/shortlog/refs/h

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 11:48:01PM +1100, Stephen Rothwell wrote: > Hi Leon, > > On Thu, 21 Feb 2019 12:34:42 + Leon Romanovsky > wrote: > > > > Matthew, really? change of API in -rc7? And it after you pushed us to > > base our -next on -rc5 after another API change? What should we do now? >

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Stephen Rothwell
Hi Leon, On Thu, 21 Feb 2019 12:34:42 + Leon Romanovsky wrote: > > Matthew, really? change of API in -rc7? And it after you pushed us to > base our -next on -rc5 after another API change? What should we do now? The xarray API changes (to xa_alloc and __xa_alloc) have been in linux-next for a

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Stephen Rothwell
Hi Jason, On Wed, 13 Feb 2019 22:09:36 + Jason Gunthorpe wrote: > > I personally think it is not good to put major logic changes in merge > commits, so I would prefer the #2 approach for this case. These are not difficult merge fixes or logic changes. > Also, the general philosophy that the

Re: linux-next: build failure after merge of the xarray tree

2019-02-21 Thread Leon Romanovsky
On Thu, Feb 21, 2019 at 05:13:32PM +1100, Stephen Rothwell wrote: > Hi all, > > After merging the xarray tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from include/linux/uio.h:12, > from include/linux/socket.h:8, >

Re: linux-next: build failure after merge of the xarray tree

2019-02-13 Thread Jason Gunthorpe
On Wed, Feb 13, 2019 at 01:26:23PM -0800, Matthew Wilcox wrote: > On Tue, Feb 12, 2019 at 04:23:31PM +, Jason Gunthorpe wrote: > > On Tue, Feb 12, 2019 at 08:15:28AM -0800, Matthew Wilcox wrote: > > > Seriously, there are several defects in the published API which do > > > warrant a change. Th

Re: linux-next: build failure after merge of the xarray tree

2019-02-13 Thread Matthew Wilcox
On Tue, Feb 12, 2019 at 04:23:31PM +, Jason Gunthorpe wrote: > On Tue, Feb 12, 2019 at 08:15:28AM -0800, Matthew Wilcox wrote: > > Seriously, there are several defects in the published API which do > > warrant a change. The most severe one is that it's really easy to > > forget to initialise t

Re: linux-next: build failure after merge of the xarray tree

2019-02-12 Thread Jason Gunthorpe
On Tue, Feb 12, 2019 at 08:15:28AM -0800, Matthew Wilcox wrote: > On Tue, Feb 12, 2019 at 04:20:03PM +1100, Stephen Rothwell wrote: > > Caused by commit > > > > a3e4d3f97ec8 ("XArray: Redesign xa_alloc API") > > > > interacting with commits > > > > e59178d895af ("RDMA/devices: Use xarray to

Re: linux-next: build failure after merge of the xarray tree

2019-02-12 Thread Matthew Wilcox
On Tue, Feb 12, 2019 at 04:20:03PM +1100, Stephen Rothwell wrote: > Caused by commit > > a3e4d3f97ec8 ("XArray: Redesign xa_alloc API") > > interacting with commits > > e59178d895af ("RDMA/devices: Use xarray to store the clients") > 0df91bb67334 ("RDMA/devices: Use xarray to store the cli

Re: linux-next: build failure after merge of the xarray tree

2018-06-26 Thread Stephen Rothwell
Hi all, On Mon, 18 Jun 2018 10:09:20 -0700 Matthew Wilcox wrote: > > On Mon, Jun 18, 2018 at 09:50:33AM -0700, Dan Williams wrote: > > On Sun, Jun 17, 2018 at 8:27 PM, Stephen Rothwell > > wrote: > > > Hi all, > > > > > > After merging the xarray tree, today's linux-next build (powerpc > > >

Re: linux-next: build failure after merge of the xarray tree

2018-06-18 Thread Matthew Wilcox
On Mon, Jun 18, 2018 at 09:50:33AM -0700, Dan Williams wrote: > On Sun, Jun 17, 2018 at 8:27 PM, Stephen Rothwell > wrote: > > Hi all, > > > > After merging the xarray tree, today's linux-next build (powerpc > > ppc64_defconfig) failed like this: [...] > > from the nvdimm tree. > > > > Willy than

Re: linux-next: build failure after merge of the xarray tree

2018-06-18 Thread Dan Williams
On Sun, Jun 17, 2018 at 8:27 PM, Stephen Rothwell wrote: > Hi all, > > After merging the xarray tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > In file included from arch/powerpc/include/asm/bug.h:128:0, > from include/linux/bug.h:5, >