Re: md: raid10: fix use-after-free of bio

2007-07-30 Thread Neil Brown
On Monday July 30, [EMAIL PROTECTED] wrote: > > > > Surely we just leaked that bio if (mirror == -1)? > > > > better: > > > > --- a/drivers/md/raid10.c~md-raid10-fix-use-after-free-of-bio > > +++ a/drivers/md/raid10.c > > @@ -1534,7 +1534,6 @@ static void raid10d(mddev_t *mddev) > >

Re: md: raid10: fix use-after-free of bio

2007-07-30 Thread Maik Hampel
Am Samstag, den 28.07.2007, 23:55 -0700 schrieb Andrew Morton: > On Fri, 27 Jul 2007 16:46:23 +0200 Maik Hampel <[EMAIL PROTECTED]> wrote: > > > In case of read errors raid10d tries to print a nice error message, > > unfortunately using data from an already put bio. > > > > Signed-off-by: Maik Ha

Re: md: raid10: fix use-after-free of bio

2007-07-28 Thread Andrew Morton
On Fri, 27 Jul 2007 16:46:23 +0200 Maik Hampel <[EMAIL PROTECTED]> wrote: > In case of read errors raid10d tries to print a nice error message, > unfortunately using data from an already put bio. > > Signed-off-by: Maik Hampel <[EMAIL PROTECTED]> > > diff --git a/drivers/md/raid10.c b/drivers/md